Skip to content

Commit 411bb80

Browse files
committed
fix: Correct use of supertrait_item_shadowing lints
These were recently renamed, and are also apparently unstable. I'm not sure how I keep failing to realize I'm using unstable lints. If I'm not mistaken, these are just about to stabilize in [rust-lang/rust!148605]. As in, the PR is currently in disposition merge. [rust-lang/rust!148605]: rust-lang/rust#148605 Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
1 parent 7f3caba commit 411bb80

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: Format Check (Nightly)
3939
run: cargo +nightly fmt --verbose --all --check
4040
- name: Clippy (Nightly)
41-
run: cargo +nightly clippy --locked --workspace --all-targets --all-features -- -D warnings -Zcrate-attr=feature"(strict_provenance_lints,unqualified_local_imports,must_not_suspend,multiple_supertrait_upcastable,non_exhaustive_omitted_patterns_lint)"
41+
run: cargo +nightly clippy --locked --workspace --all-targets --all-features -- -D warnings -Zcrate-attr=feature"(strict_provenance_lints,unqualified_local_imports,must_not_suspend,multiple_supertrait_upcastable,non_exhaustive_omitted_patterns_lint,supertrait_item_shadowing)"
4242

4343
build-test-msrv:
4444
strategy:

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ non_ascii_idents = "forbid"
111111
non_exhaustive_omitted_patterns = "warn" # unstable; #89554
112112

113113
# Shadowing silently leads to unexpected behavior
114-
supertrait_item_shadowing_definition = "warn"
115-
supertrait_item_shadowing_usage = "warn"
114+
shadowing_supertrait_items = "warn" # unstable; #89151
115+
resolving_to_items_shadowing_supertrait_items = "warn" # unstable; #89151
116116

117117
# Casting can be dangerous, I'd rather not if I don't need to
118118
trivial_casts = "warn"

maint/suggested_config.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ rustflags = [
1111
# Improves compilation times, doesn't seem to impact runtime performance
1212
"-Zthreads=8",
1313
# Unstable lints
14-
"-Zcrate-attr=feature(strict_provenance_lints,unqualified_local_imports,must_not_suspend,multiple_supertrait_upcastable,non_exhaustive_omitted_patterns_lint)",
14+
"-Zcrate-attr=feature(strict_provenance_lints,unqualified_local_imports,must_not_suspend,multiple_supertrait_upcastable,non_exhaustive_omitted_patterns_lint,supertrait_item_shadowing)",
1515
# For profiling.
1616
# "-Cforce-frame-pointers=yes",
1717
# "-Clink-arg=-Wl,--no-rosegment",

0 commit comments

Comments
 (0)