Add marketplace icon for Education Agent Skills#111
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1b872596d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "source": "github", | ||
| "path": "GarethManning/education-agent-skills" |
There was a problem hiding this comment.
This new plugin points source.source to github, but this repository’s marketplace contract and generator expect entries to be mirrored under ./plugins/ (README.md:75, build_marketplace_entry in scripts/generate_plugins_json.py:229-246). Because sync regenerates .agents/plugins/marketplace.json from README (parse_plugins + main), this manually added GitHub-backed entry will be rewritten/removed on the next sync and installs lose the repo’s reproducibility guarantee (they now depend on upstream repo state instead of the mirrored bundle).
Useful? React with 👍 / 👎.
GarethManning
force-pushed
the
add-education-agent-skills-icon
branch
from
d1b8725 to
a7a5962
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7a5962957
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "category": "Tools & Integrations", | ||
| "description": "131 evidence-based education skills for curriculum design, lesson planning, and assessment, with transparent evidence ratings and MCP server." | ||
| "description": "131 evidence-based education skills for curriculum design, lesson planning, and assessment, with transparent evidence ratings and MCP server.", | ||
| "icon": "./plugins/GarethManning/education-agent-skills/assets/education-agent-skills-icon.svg" |
There was a problem hiding this comment.
This icon was added directly to the generated marketplace artifact, but scripts/generate_plugins_json.py only emits icons from .codex-plugin/plugin.json (interface.composerIcon or interface.logo, see generation logic around lines 286–307). The plugins/GarethManning/education-agent-skills/.codex-plugin/plugin.json file currently has no interface block, so the next sync regeneration will remove this field again and the plugin-pr validator will continue failing on missing interface.composerIcon when this plugin directory is touched. Add the icon path in the plugin manifest and regenerate instead of patching marketplace.json by hand.
Useful? React with 👍 / 👎.
GarethManning
force-pushed
the
add-education-agent-skills-icon
branch
from
a7a5962 to
d6afeaf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6afeaf39f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "category": "Development & Workflow", | ||
| "description": "AI code reviews grounded in six classic engineering books — decay risk diagnostics with book citations, severity labels, and four analysis modes (PR review, architecture audit, tech debt, test quality)." | ||
| "description": "AI code reviews grounded in six classic engineering books \u2014 decay risk diagnostics with book citations, severity labels, and four analysis modes (PR review, architecture audit, tech debt, test quality).", | ||
| "icon": "./plugins/hyhmrright/brooks-lint/assets/logo.svg" |
There was a problem hiding this comment.
This entry now advertises ./plugins/hyhmrright/brooks-lint/assets/logo.svg, but that file is not present in the mirrored plugin bundle (checked plugins/hyhmrright/brooks-lint contents, which has no assets/ directory). Any marketplace consumer that tries to render this icon will hit a missing file and show a broken image, so the icon field should be removed or backed by an actual bundled asset.
Useful? React with 👍 / 👎.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| "category": "Development & Workflow", | ||
| "description": "AI code reviews grounded in six classic engineering books — decay risk diagnostics with book citations, severity labels, and four analysis modes (PR review, architecture audit, tech debt, test quality)." | ||
| "description": "AI code reviews grounded in six classic engineering books \u2014 decay risk diagnostics with book citations, severity labels, and four analysis modes (PR review, architecture audit, tech debt, test quality).", | ||
| "icon": "./plugins/hyhmrright/brooks-lint/assets/logo.svg" |
There was a problem hiding this comment.
CRITICAL: Icon file does not exist - brooks-lint plugin has no assets directory or logo.svg file. The referenced path ./plugins/hyhmrright/brooks-lint/assets/logo.svg will cause runtime errors. Found files in brooks-lint: .codex-plugin/, skills/, LICENSE, README.md, SECURITY.md, package.json
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (4 files)
Reviewed by laguna-m.1-20260312:free · 642,893 tokens |
|
The generate script keeps introducing collateral changes to other plugin entries, which I can't clean up without deeper knowledge of this repo's sync workflow. My source repo is updated with the icon and all required plugin.json fields (composerIcon, displayName, shortDescription, repository, license). Could a maintainer re-sync the mirrored bundle from GarethManning/education-agent-skills when convenient? Happy to help if anything else is needed on my side. Thanks! |
2 participants
Summary