Skip to content

Add composer icon for Personal Data Protection#117

Merged
internet-dot merged 1 commit into
hashgraph-online:mainfrom
obiot:add-pdp-icon
May 17, 2026
Merged

Add composer icon for Personal Data Protection#117
internet-dot merged 1 commit into
hashgraph-online:mainfrom
obiot:add-pdp-icon

Conversation

@obiot
Copy link
Copy Markdown
Contributor

@obiot obiot commented May 17, 2026

Follow-up to #109 per your merge comment:

Merged, but please follow up with a PR to add an icon. See CONTRIBUTING.md for the spec: add an SVG/PNG to assets/, set composerIcon in .codex-plugin/plugin.json interface section, and add the icon field in .agents/plugins/marketplace.json.

All three done in this PR.

Changes

  1. plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg (new) — 1.1 KB shield-and-lock SVG. 256×256 viewBox, gradient background (indigo #3730A3#1E1B4B), white shield enclosing a stylized lock. Reads cleanly at 32×32; no text in the mark. Well under the 50 KB cap in the icon spec.

  2. plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json — added interface.composerIcon: "./assets/icon.svg".

  3. .agents/plugins/marketplace.json — added "icon": "./plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg" to the personal-data-protection entry.

Upstream

The same icon + manifest update has also landed in the source repo at AltByteSG/personal-data-protection-skill (b13552b) so the next sync from upstream won't drift.

Validation

$ python3 scripts/validate-plugin-pr.py
Validating 1 changed plugin directory(ies)...
    ! No .codexignore file found (recommended)
Validation passed with warnings: 1 warning(s)

Only warning is the recommended-but-optional .codexignore (skipped for now to keep scope tight; ~80% of existing community plugins also don't ship one).

JSON validated locally with python3 -m json.tool on both .agents/plugins/marketplace.json and the mirror's .codex-plugin/plugin.json before push.

Follow-up to hashgraph-online#109 per maintainer request:
- New plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg
  (1.1 KB shield+lock SVG, 256x256 viewBox, reads cleanly at 32x32)
- Updated plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json
  interface.composerIcon = ./assets/icon.svg
- Added icon field to .agents/plugins/marketplace.json entry

Validator passed: python3 scripts/validate-plugin-pr.py
Copilot AI review requested due to automatic review settings May 17, 2026 00:27
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing Personal Data Protection plugin icon wiring requested after the original plugin listing PR.

Changes:

  • Adds a new SVG shield/lock icon asset.
  • References the icon from the plugin manifest via interface.composerIcon.
  • Adds the same icon path to the marketplace entry.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg Adds the new plugin icon asset.
plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json Registers the icon for Codex composer UI.
.agents/plugins/marketplace.json Exposes the icon in the marketplace listing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@internet-dot internet-dot merged commit 6deb66f into hashgraph-online:main May 17, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants