Add composer icon for Personal Data Protection#117
Merged
Conversation
Follow-up to hashgraph-online#109 per maintainer request: - New plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg (1.1 KB shield+lock SVG, 256x256 viewBox, reads cleanly at 32x32) - Updated plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json interface.composerIcon = ./assets/icon.svg - Added icon field to .agents/plugins/marketplace.json entry Validator passed: python3 scripts/validate-plugin-pr.py
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
6 tasks
There was a problem hiding this comment.
Pull request overview
Adds the missing Personal Data Protection plugin icon wiring requested after the original plugin listing PR.
Changes:
- Adds a new SVG shield/lock icon asset.
- References the icon from the plugin manifest via
interface.composerIcon. - Adds the same icon path to the marketplace entry.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg |
Adds the new plugin icon asset. |
plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json |
Registers the icon for Codex composer UI. |
.agents/plugins/marketplace.json |
Exposes the icon in the marketplace listing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #109 per your merge comment:
All three done in this PR.
Changes
plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg(new) — 1.1 KB shield-and-lock SVG. 256×256 viewBox, gradient background (indigo#3730A3→#1E1B4B), white shield enclosing a stylized lock. Reads cleanly at 32×32; no text in the mark. Well under the 50 KB cap in the icon spec.plugins/AltByteSG/personal-data-protection-skill/.codex-plugin/plugin.json— addedinterface.composerIcon: "./assets/icon.svg"..agents/plugins/marketplace.json— added"icon": "./plugins/AltByteSG/personal-data-protection-skill/assets/icon.svg"to thepersonal-data-protectionentry.Upstream
The same icon + manifest update has also landed in the source repo at AltByteSG/personal-data-protection-skill (
b13552b) so the next sync from upstream won't drift.Validation
Only warning is the recommended-but-optional
.codexignore(skipped for now to keep scope tight; ~80% of existing community plugins also don't ship one).JSON validated locally with
python3 -m json.toolon both.agents/plugins/marketplace.jsonand the mirror's.codex-plugin/plugin.jsonbefore push.