Skip to content

Add Frappe Agent#79

Merged
internet-dot merged 1 commit into
hashgraph-online:mainfrom
Dkm0315:add-frappe-agent-listing
May 6, 2026
Merged

Add Frappe Agent#79
internet-dot merged 1 commit into
hashgraph-online:mainfrom
Dkm0315:add-frappe-agent-listing

Conversation

@Dkm0315
Copy link
Copy Markdown
Contributor

@Dkm0315 Dkm0315 commented May 6, 2026

Summary

  • Add Frappe Agent to the Development & Workflow community plugin list
  • Regenerate plugins.json and the curated Codex marketplace entry
  • Mirror the installable Frappe Agent plugin bundle under plugins/Dkm0315/frappe-agent

Verification

  • python3 scripts/check-alphabetical.py README.md
  • python3 -m json.tool plugins.json
  • python3 -m json.tool .agents/plugins/marketplace.json
  • python3 -m json.tool plugins/Dkm0315/frappe-agent/.codex-plugin/plugin.json
  • node build.js

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the frappe-agent plugin, providing Frappe Framework and ERPNext-specific intelligence for Codex. The changes include a suite of specialized skills, a manifest, and updates to the marketplace and main README. Feedback identifies a path error in the plugin manifest and a mismatch between the plugin's documentation and the actual files provided, specifically regarding missing directories for other agent platforms.

Comment thread plugins/Dkm0315/frappe-agent/.codex-plugin/plugin.json
Comment thread plugins/Dkm0315/frappe-agent/README.md
@Dkm0315 Dkm0315 force-pushed the add-frappe-agent-listing branch from 9ab5287 to 1889c60 Compare May 6, 2026 09:57
Comment thread plugins/Dkm0315/frappe-agent/.claude-plugin/plugin.json Outdated
Comment thread plugins/Dkm0315/frappe-agent/.claude-plugin/plugin.json Outdated
Comment thread plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json Outdated
Comment thread plugins/Dkm0315/frappe-agent/.claude-plugin/marketplace.json Outdated
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 6, 2026

Code Review Summary

Status: 6 Issues Found (unchanged) | Recommendation: Address critical schema and configuration issues before merge

Overview

Severity Count
CRITICAL 3
WARNING 3
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json 10 Missing required source discriminator — plugins[].source must include "source": "local" to be valid Codex marketplace JSON.
plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json 10 Invalid path value "./" — Codex rejects empty path after stripping ./; must point to subdirectory like "./plugins/Dkm0315/frappe-agent".
plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json 14 Invalid authentication policy "ON_FIRST_USE" — accepted values are "ON_INSTALL" or "ON_USE".

WARNING

File Line Issue
plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json 16 Category "Developer Tools" is inconsistent with the canonical "Development & Workflow" used in the main curated list (README and plugins.json).
plugins/Dkm0315/frappe-agent/.codex-plugin/plugin.json 28 Interface category "Developer Tools" differs from "Development & Workflow" — standardize for consistency.
plugins/Dkm0315/frappe-agent/.codex-plugin/plugin.json 22 Skills path ./skills/ may be invalid depending on manifest resolution rules; if resolved relative to manifest location it points to .codex-plugin/skills/ which doesn't exist. Consider confirming with Codex plugin loader expectations or using ../skills/ as alternative.
Other Observations (not in diff but still present)

No additional observations.

Files Reviewed (2 files)
  • .agents/plugins/marketplace.json — critical schema errors
  • .codex-plugin/plugin.json — category mismatch and skills path concern

Note: No code changes in this incremental update — all 6 previously identified issues remain open. The three CRITICAL schema errors in .agents/plugins/marketplace.json will prevent the plugin from loading correctly from the bundled marketplace. The .claude-plugin files were previously removed from the PR, resolving those concerns.


Reviewed by step-3.5-flash · 1,213,982 tokens

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1889c608f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json Outdated
Comment thread plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json Outdated
Comment thread plugins/Dkm0315/frappe-agent/.agents/plugins/marketplace.json Outdated
@Dkm0315 Dkm0315 force-pushed the add-frappe-agent-listing branch from 1889c60 to c739189 Compare May 6, 2026 10:04
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c739189bbe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +15
"skills": "../skills/",
"commands": [
"../commands/"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use plugin-root relative paths in Claude manifest

Claude plugin component paths must be relative and start with ./, but this manifest points to ../skills/ and ../commands/. In Claude Code, component paths are resolved from the plugin root and cannot traverse outside it, so these entries prevent the plugin from discovering its bundled skills/commands after install, effectively breaking the advertised Claude package behavior.

Useful? React with 👍 / 👎.

@Dkm0315 Dkm0315 force-pushed the add-frappe-agent-listing branch from c739189 to 56c5416 Compare May 6, 2026 10:21
"shortDescription": "Frappe-aware coding, bench, SQL, and customization help.",
"longDescription": "Adds Frappe and ERPNext-specific skills for full-stack work, bench operations, SQL and ORM decisions, admin customizations, and workflow-aware code review.",
"developerName": "Dhairya Marwaha",
"category": "Developer Tools",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Category "Developer Tools" differs from the canonical "Development & Workflow" used in the curated plugins list (README and plugins.json). Use consistent categorization.

Suggested change
"category": "Developer Tools",
"category": "Development & Workflow",

@Dkm0315 Dkm0315 force-pushed the add-frappe-agent-listing branch from 56c5416 to cfd5f83 Compare May 6, 2026 10:37
@Dkm0315
Copy link
Copy Markdown
Contributor Author

Dkm0315 commented May 6, 2026

Follow-up on the latest bot comments:

  • The mirrored Frappe Agent bundle is now Codex-only; the Claude/Cursor/Copilot adapter files that triggered path/schema comments were removed from this curated mirror.
  • The root curated marketplace entry already includes source: "local", path: "./plugins/Dkm0315/frappe-agent", authentication: "ON_INSTALL", and category: "Development & Workflow".
  • The mirrored Codex manifest category is now also Development & Workflow.
  • Local verification passed: alphabetical check, JSON validation, and node build.js.

@internet-dot internet-dot merged commit e9da02c into hashgraph-online:main May 6, 2026
1 check passed
internet-dot added a commit that referenced this pull request May 6, 2026
…etical README + regenerate artifacts

- Agentizer (Humiris) — Development & Workflow
- Antigravity Workspace Template (study8677) — Development & Workflow
- Bring Your AI Migration Auditor (unitedideas) — Development & Workflow
- Frappe Agent (Dkm0315) — Development & Workflow
- Canvas Apps Plugin Codex (Ratnam-Mishra) — Tools & Integrations

README sections sorted alphabetically per scripts/check-alphabetical.py (all 5 sections pass).
plugins.json: regenerated (60 plugins total)
.agents/plugins/marketplace.json: updated with all 5 new entries
@internet-dot
Copy link
Copy Markdown
Collaborator

✅ All changes from this PR have been merged directly into main via a consolidated commit (dc35fb0) to fix fork-based CI failures and ensure README alphabetical order + artifact sync.
Closing this PR as its content is already integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants