Add Frappe Agent#79
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the frappe-agent plugin, providing Frappe Framework and ERPNext-specific intelligence for Codex. The changes include a suite of specialized skills, a manifest, and updates to the marketplace and main README. Feedback identifies a path error in the plugin manifest and a mismatch between the plugin's documentation and the actual files provided, specifically regarding missing directories for other agent platforms.
9ab5287 to
1889c60
Compare
Code Review SummaryStatus: 6 Issues Found (unchanged) | Recommendation: Address critical schema and configuration issues before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
Other Observations (not in diff but still present)No additional observations. Files Reviewed (2 files)
Note: No code changes in this incremental update — all 6 previously identified issues remain open. The three CRITICAL schema errors in Reviewed by step-3.5-flash · 1,213,982 tokens |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1889c608f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1889c60 to
c739189
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c739189bbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "skills": "../skills/", | ||
| "commands": [ | ||
| "../commands/" |
There was a problem hiding this comment.
Use plugin-root relative paths in Claude manifest
Claude plugin component paths must be relative and start with ./, but this manifest points to ../skills/ and ../commands/. In Claude Code, component paths are resolved from the plugin root and cannot traverse outside it, so these entries prevent the plugin from discovering its bundled skills/commands after install, effectively breaking the advertised Claude package behavior.
Useful? React with 👍 / 👎.
c739189 to
56c5416
Compare
| "shortDescription": "Frappe-aware coding, bench, SQL, and customization help.", | ||
| "longDescription": "Adds Frappe and ERPNext-specific skills for full-stack work, bench operations, SQL and ORM decisions, admin customizations, and workflow-aware code review.", | ||
| "developerName": "Dhairya Marwaha", | ||
| "category": "Developer Tools", |
There was a problem hiding this comment.
WARNING: Category "Developer Tools" differs from the canonical "Development & Workflow" used in the curated plugins list (README and plugins.json). Use consistent categorization.
| "category": "Developer Tools", | |
| "category": "Development & Workflow", |
56c5416 to
cfd5f83
Compare
|
Follow-up on the latest bot comments:
|
…etical README + regenerate artifacts - Agentizer (Humiris) — Development & Workflow - Antigravity Workspace Template (study8677) — Development & Workflow - Bring Your AI Migration Auditor (unitedideas) — Development & Workflow - Frappe Agent (Dkm0315) — Development & Workflow - Canvas Apps Plugin Codex (Ratnam-Mishra) — Tools & Integrations README sections sorted alphabetically per scripts/check-alphabetical.py (all 5 sections pass). plugins.json: regenerated (60 plugins total) .agents/plugins/marketplace.json: updated with all 5 new entries
|
✅ All changes from this PR have been merged directly into |
Summary
plugins.jsonand the curated Codex marketplace entryplugins/Dkm0315/frappe-agentVerification
python3 scripts/check-alphabetical.py README.mdpython3 -m json.tool plugins.jsonpython3 -m json.tool .agents/plugins/marketplace.jsonpython3 -m json.tool plugins/Dkm0315/frappe-agent/.codex-plugin/plugin.jsonnode build.js