#64 Fix desktop instructions#91
Conversation
hashgraph-online#64 Fix desktop instructions
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README documentation for the Desktop App and IDE Extension, specifically refining the steps to add plugin marketplace sources and updating the source URL. Feedback includes a suggestion to remove extra whitespace for better formatting and a recommendation to use an HTTPS URL instead of an SSH link to improve compatibility for users without configured SSH keys.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
SUGGESTION
Other Observations (not in diff)No other observations. Files Reviewed (1 file)
Reviewed by step-3.5-flash · 964,577 tokens |
There was a problem hiding this comment.
Pull request overview
Updates the README’s Codex Desktop / IDE Extension setup instructions to address Issue #64 (“Install instructions don't work”) by changing where/how users add this repo as a marketplace source.
Changes:
- Adjusts the Desktop App / IDE Extension navigation steps for adding a marketplace source.
- Replaces the previously suggested raw
marketplace.jsonURL with a Git repository reference.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a2262aca2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@romanr Awesome suggestion. We'll merge this in :) |
|
|
||
| **Desktop App / IDE Extension:** | ||
| 1. Open Codex settings → Plugins → Marketplace Sources | ||
| 1. Open Codex settings → Plugins → Next to search plugins input click on menu and select → `+Add More...` |
There was a problem hiding this comment.
SUGGESTION: Instruction uses arrow symbols (→) as sentence separators, making it hard to read.
Consider breaking into clearer sentences, e.g.:
"Open Codex settings → Plugins. Next to the search input, click the menu and select +Add More...."
The current run-on style hurts scanability.
| **Desktop App / IDE Extension:** | ||
| 1. Open Codex settings → Plugins → Marketplace Sources | ||
| 1. Open Codex settings → Plugins → Next to search plugins input click on menu and select → `+Add More...` | ||
| <img width="1462" height="466" alt="image" src="https://github.com/user-attachments/assets/ae15f505-58a8-4199-bb7b-56a07b670b10" /> |
There was a problem hiding this comment.
SUGGESTION: Image embedded via user-attachment URL (github.com/user-attachments/...).
These URLs are not permanent across forks or if the user deletes their attachment. For long-lived documentation, commit images to the repository and reference via relative paths.
| 2. Add this URL: | ||
| ``` | ||
| https://raw.githubusercontent.com/hashgraph-online/awesome-codex-plugins/main/.agents/plugins/marketplace.json | ||
| https://github.com/hashgraph-online/awesome-codex-plugins.git |
There was a problem hiding this comment.
CRITICAL: Invalid marketplace source URL.
https://github.com/hashgraph-online/awesome-codex-plugins.git is a GitHub repository page URL, not a Codex marketplace source.
Codex expects a direct URL to a marketplace.json file. The correct URL is:
| https://github.com/hashgraph-online/awesome-codex-plugins.git | |
| https://raw.githubusercontent.com/hashgraph-online/awesome-codex-plugins/main/.agents/plugins/marketplace.json |
Using the repository URL will cause plugin installation to fail.
| https://raw.githubusercontent.com/hashgraph-online/awesome-codex-plugins/main/.agents/plugins/marketplace.json | ||
| https://github.com/hashgraph-online/awesome-codex-plugins.git | ||
| ``` | ||
| <img width="1974" height="1064" alt="image" src="https://github.com/user-attachments/assets/ffbae59f-41ae-4ee3-9d52-864273ecdcb3" /> |
There was a problem hiding this comment.
SUGGESTION: Second user-attachment image (same portability concern as the previous image).
Consider committing these screenshots to the repository assets and referencing them with stable relative paths.
#64 Fix desktop instructions