test(contracts): reset orchestrator-library state leaked by registry unit suite

The atsRegistry.generated unit suite seeds zero-address orchestrator library
placeholders into a shared module singleton to construct facet factories in
isolation, but never cleared them. Running the scripts suite on its own then
leaked those zeros into later token deployments, linking scheduledTasksOps to
address(0) and reverting initializeERC20. Add resetOrchestratorLibraryAddresses()
and clear only the seeded state in an after hook.

Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>

Author: MiguelLZPF

packages/ats/contracts/scripts/domain/orchestratorLibraries.ts

@@ -94,6 +94,18 @@ export function hasOrchestratorLibraryAddresses(): boolean {
   return _addresses !== undefined;
 }
 
+/**
+ * Reset orchestrator library addresses to the unset state.
+ *
+ * Intended for test isolation: a suite that seeds placeholder addresses (e.g. to
+ * construct facet factories without a real deployment) must reset afterwards, so a
+ * later deployment re-links the actually-deployed libraries instead of inheriting
+ * the placeholders through this module-level singleton.
+ */
+export function resetOrchestratorLibraryAddresses(): void {
+  _addresses = undefined;
+}
+
 /**
  * Determine which orchestrator libraries a facet requires for TypeChain linking.
  *

packages/ats/contracts/test/scripts/unit/domain/atsRegistry.generated.test.ts

@@ -31,6 +31,7 @@ import {
   isLibraryDependentFacet,
   hasOrchestratorLibraryAddresses,
   setOrchestratorLibraryAddresses,
+  resetOrchestratorLibraryAddresses,
 } from "@scripts/domain";
 
 describe("atsRegistry.generated - Factory Functions", () => {
@@ -39,6 +40,10 @@ describe("atsRegistry.generated - Factory Functions", () => {
   // Cache signer to avoid repeated Hardhat network bootstrap (saves ~4+ seconds)
   let signer: Awaited<ReturnType<typeof ethers.getSigners>>[0];
 
+  // Tracks whether THIS suite seeded the placeholder library addresses, so the
+  // after-hook only clears state it actually introduced.
+  let didSeedLibAddresses = false;
+
   before(async () => {
     [signer] = await ethers.getSigners();
     // Self-sufficient unit-suite bootstrap: when this file runs in isolation
@@ -60,6 +65,18 @@ describe("atsRegistry.generated - Factory Functions", () => {
         scheduledTasksOps: zero,
         scheduledTasksDispatchOps: zero,
       });
+      didSeedLibAddresses = true;
+    }
+  });
+
+  // Reset the module singleton if we seeded it, so a later integration deployment
+  // in the same process re-links the real orchestrator libraries rather than
+  // inheriting these zero placeholders (which would make token init delegatecall a
+  // no-code address and revert). Without this, running the scripts suite on its own
+  // poisons upgradeConfigurations' proxy-update deployments.
+  after(() => {
+    if (didSeedLibAddresses) {
+      resetOrchestratorLibraryAddresses();
     }
   });