Skip to content

refactor: deploy only equity, bond and deposit tokens#1327

Open
MiguelLZPF wants to merge 2 commits into
developfrom
feat/BBND-1882-deploy-only-equity-bond-deposit
Open

refactor: deploy only equity, bond and deposit tokens#1327
MiguelLZPF wants to merge 2 commits into
developfrom
feat/BBND-1882-deploy-only-equity-bond-deposit

Conversation

@MiguelLZPF

Copy link
Copy Markdown
Contributor

Description

BBND-1882 [SERVICING] — deploy-layer cleanup.

Clean the deploy scripts and Factory so the system deploys only Equity, Bond (variable-rate) and DepositToken. Removes the Loan, LoansPortfolio, BondFixedRate and BondKpiLinkedRate deploy configurations, the Factory `SecurityType` entries for them, their deploy fixtures and per-type deploy tests, and renumbers the deployment-workflow steps and checkpoint indices. The underlying Solidity facets for those types are intentionally retained (deploy-layer only) and remain exercised by the shared AssetMock mega-asset; the deprecated SDK and the web app are untouched.

Note for reviewers: The Factory `SecurityType` enum was trimmed, which shifts `DepositToken`'s ordinal from 5 to 2. All Solidity references use the enum by name, so this is ABI-enum-visible but internally safe.

Jira: https://iobuilders.atlassian.net/browse/BBND-1882

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

  • `npm run ats:contracts:build` ✅
  • `npm run ats:contracts:lint` ✅ (0 errors, solhint 181 warnings = baseline)
  • `ATS_TEST_MODE=true npx hardhat test test/contracts/integration/ats.test.ts` → 2408 passing, 0 failing ✅
  • `ATS_TEST_MODE=true npx hardhat test test/contracts/integration/factory/factory.test.ts` → 39 passing ✅
  • facetSets, checkpoint, deploymentFiles unit suites pass ✅

All gates run locally.

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Note: per-type deploy tests were removed as part of this cleanup. Coverage for those paths should be reviewed by the author before merging.

@MiguelLZPF MiguelLZPF self-assigned this Jun 25, 2026
@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1882-deploy-only-equity-bond-deposit branch 3 times, most recently from 3566d9a to d4c3625 Compare June 25, 2026 07:23
@MiguelLZPF MiguelLZPF marked this pull request as ready for review June 25, 2026 08:01
@MiguelLZPF MiguelLZPF requested review from a team as code owners June 25, 2026 08:01
@MiguelLZPF MiguelLZPF requested a review from Neurone June 25, 2026 08:02
@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1882-deploy-only-equity-bond-deposit branch from d4c3625 to ebd8652 Compare June 25, 2026 09:01
Clean the deploy scripts and Factory so only Equity, Bond and DepositToken
are deployed, removing the Loan, LoansPortfolio, BondFixedRate and
BondKpiLinkedRate deploy configurations, the Factory SecurityType entries
for them, their deploy fixtures and per-type deploy tests, and renumbering
the deployment workflow steps. The underlying Solidity facets are retained
and still exercised by the shared AssetMock mega-asset.

BBND-1882

Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
@MiguelLZPF MiguelLZPF force-pushed the feat/BBND-1882-deploy-only-equity-bond-deposit branch from a1087d2 to 7e34f77 Compare June 25, 2026 09:56
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant