Skip to content

docs(claude): require Resolution hints on every StepFailureReport#800

Merged
brunodam merged 2 commits into
mainfrom
docs/resolution-hints-convention
Jul 3, 2026
Merged

docs(claude): require Resolution hints on every StepFailureReport#800
brunodam merged 2 commits into
mainfrom
docs/resolution-hints-convention

Conversation

@brunodam

@brunodam brunodam commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a mandatory coding standard to CLAUDE.md: every automa.StepFailureReport
must include a WithProperty(models.ErrPropertyResolution, []string{...}) block
listing operator-actionable steps to resolve the failure.

This pattern is already consistent across the codebase — this entry makes it
explicit so it is enforced on all future PRs rather than caught in review.

Related Issues

Every automa.StepFailureReport must include a
WithProperty(models.ErrPropertyResolution, []string{...}) block
listing operator-actionable steps. Added to Key Conventions so the
rule is enforced consistently across all future PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Bruno Marques <bruno.marques@swirldslabs.com>
Copilot AI review requested due to automatic review settings July 2, 2026 20:44
@brunodam brunodam requested a review from a team as a code owner July 2, 2026 20:44
@brunodam brunodam requested a review from tomzhenghedera July 2, 2026 20:44
@swirlds-automation

swirlds-automation commented Jul 2, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s contributor guidance to explicitly require resolution hints on all automa.StepFailureReport failures, so operators get actionable remediation steps surfaced in the TUI and error output.

Changes:

  • Add a new coding standard to CLAUDE.md requiring ErrPropertyResolution hints for every automa.StepFailureReport.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CLAUDE.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Bruno Marques <bruno.marques@swirldslabs.com>

@alex-au alex-au left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should always do that

@brunodam brunodam merged commit 9c89eab into main Jul 3, 2026
20 checks passed
@brunodam brunodam deleted the docs/resolution-hints-convention branch July 3, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants