Compare the unit test fixes for control-plane/subcommand/sync-catalog only #5271
Draft
Manishakumari-hc wants to merge 32 commits into
Draft
Compare the unit test fixes for control-plane/subcommand/sync-catalog only #5271Manishakumari-hc wants to merge 32 commits into
Manishakumari-hc wants to merge 32 commits into
Conversation
* Add secret watch to terminating gateway controller logic * add tests * update test acceptance tests * update test acceptance tests * removing acceptance tests
…policy added "component: api-gateway" for stable controller and "component: api-gateway-consul" for custom controller. Added kind check in the gatewaypolicies. Webhook denies the policy if targetRef.kind is not Gateway.
* temp commit * feat: add HPA support for API gateway scaling with annotations * feat: gate API Gateway scaling behind enterprise flag * feat: add default value for apiGateway openshiftSCCName and improve tests * feat: verify HPA ownership before deletion in api gateway scaling * style(api-gateway): add periods to comment sentences in scaling code for lint issues * add changelog * feat: gate API gateway scaling behind enterprise license validation * test(connect-inject): improve openshift SCC test selector reliability * fix(consul): prevent config mutation by cloning in IsEnterpriseDistribution * api gateway scaling integration tests (#5201) * temp commit * feat: add HPA support for API gateway scaling with annotations * feat: gate API Gateway scaling behind enterprise flag * test(api-gateway): add scaling integration tests for HPA and replica management * fix removed license and test for enterprise license check * test(api-gateway): add controller restart for enterprise license detection * add restart controller to all enterprise gate enabled --------- Co-authored-by: P Ajay Rao <pajay.rao@hashicorp.com>
* kind test check * Update kind_acceptance_test_packages.yaml * Update api_gateway_lifecycle_test.go * final reconcile for previously controlled gateway * Update api_gateway_lifecycle_test.go * log check * Update api_gateway_lifecycle_test.go * Update api_gateway_lifecycle_test.go * Update gateway_controller.go * Update api_gateway_lifecycle_test.go * Update gateway_controller.go * fixed api-gateway lifecycle testcase * enable all tcs * verify the cross partiton case * use last version image for consul * Update partitions_gateway_test.go * new image * Update partitions_gateway_test.go * Update values.yaml * revert to what is needed * lint * enable gatewayclass; add labels introduced in new manifests * Update command.go
* Update submodules * Update changelogs
* kind test check * Update kind_acceptance_test_packages.yaml * Update api_gateway_lifecycle_test.go * final reconcile for previously controlled gateway * Update api_gateway_lifecycle_test.go * log check * Update api_gateway_lifecycle_test.go * Update api_gateway_lifecycle_test.go * Update gateway_controller.go * Update api_gateway_lifecycle_test.go * Update gateway_controller.go * fixed api-gateway lifecycle testcase * enable all tcs * verify the cross partiton case * use last version image for consul * Update partitions_gateway_test.go * new image * Update partitions_gateway_test.go * Update values.yaml * revert to what is needed * lint * enable gatewayclass; add labels introduced in new manifests * Update command.go * fixed UT with fake client * fix UTs * fix: added test in custom api gateway (#5242) * fix: added test in custom api gateway * docs: added note explaining why we are not going with event based waiting * removed for rc1, should be fixed later * remove unused func * Update command.go * comment functions required only for test till UT is fixed --------- Co-authored-by: Kruti Baraiya <baraiyakruti@gmail.com>
…into dinesh/ocp
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
Manishakumari-hc
changed the base branch from
dinesh/ocp
to
manisha/all_ocp_tests
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
Manishakumari-hc
changed the title
krutibaraiya
reviewed
May 6, 2026
Comment on lines
+50
to
+52
| type settableGates interface { | ||
| Set(feature clientfeatures.Feature, value bool) error | ||
| } |
Member
There was a problem hiding this comment.
Can we move this interface definition at package level instead of defining inline - for better code organisation and reusability?
Member
There was a problem hiding this comment.
Also this function TestMain is handling two unrelated concerns so it makes more sense to move the gate setting interface out of it
Collaborator
Author
There was a problem hiding this comment.
Addressed by moving the interface out of the function at package level.
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
Manishakumari-hc
changed the title
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync_Catalog_testResult.log