Skip to content

Fix for CI Lint failure #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritikrajdev merged 3 commits into from
Mar 12, 2026
+3 −0
Merged

Fix for CI Lint failure #147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8a7ce7
fix: use specific version of golangci
ritikrajdev Mar 9, 2026
1de9745
use v2.8.0 for golangci-lint
ritikrajdev Mar 9, 2026
9d406d1
chore: use newer version for golangci-lint
ritikrajdev Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/go-multierror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ jobs:
- name: Setup go
uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
with:
# go version file has the minimum supported version of go - 1.13
go-version-file: go.mod
- name: Run golangci-lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20
with:
version: v2.8.0

@sonamtenzin2 sonamtenzin2 Mar 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchoring the linter action to a specific action may make the updates to golangci/golangci-lint-action.
Were the failures happening due to 1.13 ? If so, we can probably look into increasing the go version itself

@ritikrajdev ritikrajdev Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go multierror recommends inbuilt errors library to be use in case of newer versions. I would not recommend upgrading to newer version here.


linux-tests:
runs-on: ubuntu-latest
Expand Down