batch queue: add queue initialization to server#27953
Merged
Merged
Conversation
mismithhisler
commented
May 12, 2026
tgross
requested changes
May 13, 2026
Golang introduced routing enhancements in 1.22, but Nomad cannot utilize these and also allow a forward slash in the job ID
allisonlarson
approved these changes
May 21, 2026
Contributor
allisonlarson
left a comment
There was a problem hiding this comment.
This makes sense to me! Keeping the queue routing in the FSM feels like the right move, to echo @tgross in the earlier review, even if it is a bit wonky right now.
Member
Author
|
@tgross @allisonlarson Agreed that doing this in the FSM ended up being the best route. Also, injecting the state via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes add the create and start of a batch queue interface implementation to the Nomad server, along with changes to how we route job registration evaluations, so batch job evaluations are routed to the batch job queue.
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.