client: offer a json backend for the state store#28040
Draft
schmichael wants to merge 3 commits into
Draft
Conversation
and does not work as is
writes clients state to a file as json uses a temporary file + rename to perform an atomic write on unix uses a lock file to hopefully prevent disaster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by @pkazmierczak's work in #27934 and Tailscale, I wanted to explore the "simplest" possible client state solution that was still reasonably safe. So here's a json backend for our client state that has to perform like complete garbage. If only I had written the bolt de-duplication layer in c0d1b63 generically so it could be reused here. 🤷
Testing & Reproduction steps
No tests. Do Not merge.
Should probably fsync the directory itself to ensure crash safety like raft-wal does: https://github.com/hashicorp/raft-wal/blob/f9846d205596489efa6a2a04d72a564a7fecbe44/fs/fs.go#L117-L128
Easiest way to test is to edit this line to return
NewJsonDB:nomad/client/state/db_bolt.go
Line 173 in 83ef3d0
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.