Add unit tests for oslogin_ssh_key_expire_after parameter

- Enhance DriverMock to capture expiration time parameter
- Add TestStepImportOSLoginSSHKey_withExpirationTime to verify expiration time is calculated and passed correctly
- Add TestStepImportOSLoginSSHKey_withoutExpirationTime to verify expiration time is nil when not set
- Tests follow existing test patterns in step_import_os_login_ssh_key_test.go

Author: y1hao

builder/googlecompute/step_import_os_login_ssh_key_test.go

@@ -9,7 +9,9 @@ import (
 	"encoding/hex"
 	"os"
 	"testing"
+	"time"
 
+	"github.com/hashicorp/packer-plugin-googlecompute/lib/common"
 	"github.com/hashicorp/packer-plugin-sdk/multistep"
 	configsdk "github.com/hashicorp/packer-plugin-sdk/template/config"
 	"google.golang.org/api/oauth2/v2"
@@ -309,3 +311,79 @@ func TestGetOSLoginUsername(t *testing.T) {
 		})
 	}
 }
+
+func TestStepImportOSLoginSSHKey_withExpirationTime(t *testing.T) {
+	state := testState(t)
+	fakeAccountEmail := "raffi-compute@developer.gserviceaccount.com"
+	driver := state.Get("driver").(*common.DriverMock)
+	step := &StepImportOSLoginSSHKey{
+		TokeninfoFunc: func() (*oauth2.Tokeninfo, error) {
+			return &oauth2.Tokeninfo{Email: fakeAccountEmail}, nil
+		},
+	}
+	defer step.Cleanup(state)
+
+	config := state.Get("config").(*Config)
+	config.UseOSLogin = configsdk.TriTrue
+	config.Comm.SSHPublicKey = []byte{'k', 'e', 'y'}
+	config.OSLoginSSHKeyExpireAfter = 1 * time.Hour
+
+	beforeTime := time.Now()
+	if action := step.Run(context.Background(), state); action != multistep.ActionContinue {
+		t.Fatalf("bad action: %#v", action)
+	}
+	afterTime := time.Now()
+
+	if driver.ImportOSLoginSSHKeyExpirationTime == nil {
+		t.Fatal("expected expiration time to be set, but got nil")
+	}
+
+	expectedExpirationMin := beforeTime.Add(config.OSLoginSSHKeyExpireAfter).UnixMicro()
+	expectedExpirationMax := afterTime.Add(config.OSLoginSSHKeyExpireAfter).UnixMicro()
+	actualExpiration := *driver.ImportOSLoginSSHKeyExpirationTime
+
+	if actualExpiration < expectedExpirationMin || actualExpiration > expectedExpirationMax {
+		t.Errorf("expected expiration time to be between %d and %d, but got %d", expectedExpirationMin, expectedExpirationMax, actualExpiration)
+	}
+
+	if driver.ImportOSLoginSSHKeyUser != fakeAccountEmail {
+		t.Errorf("expected user to be %q, but got %q", fakeAccountEmail, driver.ImportOSLoginSSHKeyUser)
+	}
+
+	if driver.ImportOSLoginSSHKeyKey != "key" {
+		t.Errorf("expected key to be %q, but got %q", "key", driver.ImportOSLoginSSHKeyKey)
+	}
+}
+
+func TestStepImportOSLoginSSHKey_withoutExpirationTime(t *testing.T) {
+	state := testState(t)
+	fakeAccountEmail := "raffi-compute@developer.gserviceaccount.com"
+	driver := state.Get("driver").(*common.DriverMock)
+	step := &StepImportOSLoginSSHKey{
+		TokeninfoFunc: func() (*oauth2.Tokeninfo, error) {
+			return &oauth2.Tokeninfo{Email: fakeAccountEmail}, nil
+		},
+	}
+	defer step.Cleanup(state)
+
+	config := state.Get("config").(*Config)
+	config.UseOSLogin = configsdk.TriTrue
+	config.Comm.SSHPublicKey = []byte{'k', 'e', 'y'}
+	config.OSLoginSSHKeyExpireAfter = 0 // Not set
+
+	if action := step.Run(context.Background(), state); action != multistep.ActionContinue {
+		t.Fatalf("bad action: %#v", action)
+	}
+
+	if driver.ImportOSLoginSSHKeyExpirationTime != nil {
+		t.Errorf("expected expiration time to be nil when not set, but got %v", *driver.ImportOSLoginSSHKeyExpirationTime)
+	}
+
+	if driver.ImportOSLoginSSHKeyUser != fakeAccountEmail {
+		t.Errorf("expected user to be %q, but got %q", fakeAccountEmail, driver.ImportOSLoginSSHKeyUser)
+	}
+
+	if driver.ImportOSLoginSSHKeyKey != "key" {
+		t.Errorf("expected key to be %q, but got %q", "key", driver.ImportOSLoginSSHKeyKey)
+	}
+}

lib/common/driver_mock.go

@@ -124,6 +124,10 @@ type DriverMock struct {
 	UploadToBucketData       io.Reader
 	UploadToBucketResult     string
 	UploadToBucketError      error
+
+	ImportOSLoginSSHKeyUser           string
+	ImportOSLoginSSHKeyKey            string
+	ImportOSLoginSSHKeyExpirationTime *int64
 }
 
 func (d *DriverMock) CreateImage(project string, imageSpec *compute.Image) (<-chan *Image, <-chan error) {
@@ -380,6 +384,9 @@ func (d *DriverMock) CreateOrResetWindowsPassword(instance, zone string, c *Wind
 }
 
 func (d *DriverMock) ImportOSLoginSSHKey(user, key string, expirationTimeUsec *int64) (*oslogin.LoginProfile, error) {
+	d.ImportOSLoginSSHKeyUser = user
+	d.ImportOSLoginSSHKeyKey = key
+	d.ImportOSLoginSSHKeyExpirationTime = expirationTimeUsec
 	account := oslogin.PosixAccount{Primary: true, Username: "testing_packer_io"}
 	profile := oslogin.LoginProfile{
 		PosixAccounts: []*oslogin.PosixAccount{&account},