Skip to content

Helm Chart: values.yaml error in PodDisruptionBudget section #1250

@bryantidd

Description

@bryantidd

Describe the bug
In the following section of the values.yaml file, the maxUnavailable and minAvailable are both set. If someone sets the podDisruptionBudget.enabled: true this causes an error in the generated resource because both cannot be set.

It would be best to comment both out of the values.yaml and leave the existing comments for the user.

Configures the PodDisruptionBudget for the controller deployment.

podDisruptionBudget:

# Toggles the deployment of the PodDisruptionBudget for the controller.
# @type: boolean
enabled: false

# Sets the maximum number of unavailable pods during eviction.
# You cannot set both `maxUnavailable` and `minAvailable`.
# You can specify `maxUnavailable` as an integer ("2") or a percentage ("50%").
# @type: string
maxUnavailable: "0"

# Sets the minimum number of available pods allowed during eviction.
# You cannot set both `minAvailable` and `maxUnavailable`.
# You can specify `minAvailable` as an integer ("2") or a percentage ("50%").
# @type: string
minAvailable: "0"

To Reproduce
Steps to reproduce the behavior:

  1. Install helm chart with set controller.podDisruptionBudget.enabled=true
  2. Se error in PodDisruptionBudget resource

Expected behavior
The resource should be created without error as neither the maxUnavailable or minAvailable should be set by default.

Environment

  • Kubernetes version:
    All recent versions of Kubernetes
  • vault-secrets-operator version:
    Has been in error since the podDisruptionBudget section was added including 1.0.0 thru 1.3.0

Additional context
Appears not to have been tested

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions