Add prefix support to password policies#31959
Open
wahajahmed010 wants to merge 1 commit into
Open
Conversation
This adds a 'prefix' field to password policy configuration, allowing generated passwords to include a configurable prefix. This enables secret scanning tools to detect Vault-generated passwords. Fixes hashicorp#31889
|
Someone is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Wahaj Ahmed seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
Author
|
CLA has been signed. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
prefixfield to password policy configuration in HashiCorp Vault, allowing generated passwords to include a configurable prefix string.Problem
Currently, Vault-generated passwords have no prefix, making them impossible to identify with secret scanning tools. Vault already uses prefixes for its own tokens (e.g.,
hvs.for secrets), so this follows an existing pattern.Changes
vault/logical_system.go: AddedPrefixfield topasswordPolicyConfigstruct; updatedhandlePoliciesPasswordSetto accept and store prefix; updatedhandlePoliciesPasswordGetto return prefix; updatedhandlePoliciesPasswordGenerateto prepend prefix to generated passwordsvault/dynamic_system_view.go: UpdatedgeneratePasswordto prepend prefix when setvault/logical_system_paths.go: Addedprefixfield topasswordPolicySchemavault/logical_system_test.go: Added tests for prefix functionality (with prefix, empty prefix)Usage Example
Files Changed
vault/logical_system.go(+9 lines)vault/dynamic_system_view.go(+9 lines)vault/logical_system_paths.go(+4 lines)vault/logical_system_test.go(+102 lines)Closes #31889