Skip to content

[Snyk] Security upgrade @google-cloud/nodejs-repo-tools from 2.3.6 to 3.0.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashim21223445 merged 1 commit into from
Sep 25, 2025
Merged

[Snyk] Security upgrade @google-cloud/nodejs-repo-tools from 2.3.6 to 3.0.0 #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"uuid": "^3.1.0"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^2.1.3",
"@google-cloud/nodejs-repo-tools": "^3.0.0",

Copilot AI Sep 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major version upgrade (2.x to 3.0.0) which may introduce breaking changes. The package.json shows version ^2.1.3 being upgraded to ^3.0.0, but the PR description mentions upgrading from 2.3.6. Please verify the current version and ensure all breaking changes are documented and tested before merging.

Suggested change
"@google-cloud/nodejs-repo-tools": "^3.0.0",
"@google-cloud/nodejs-repo-tools": "^2.3.6", // NOTE: Upgrading from 2.3.6 to 3.0.0 is a major version change. Ensure all breaking changes are documented and tested before merging.

Copilot uses AI. Check for mistakes.

@gemini-code-assist gemini-code-assist Bot Sep 25, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This upgrade to a new major version (v2 to v3) introduces breaking changes, which can disrupt CI/CD processes that rely on repo-tools. While most dependencies in this project use ^ to allow minor updates, for a critical build tool undergoing a major version change, it's safer to pin the version. This prevents future 3.x releases from being pulled automatically and potentially breaking the build, allowing for more controlled, deliberate upgrades in the future.

Suggested change
"@google-cloud/nodejs-repo-tools": "^3.0.0",
"@google-cloud/nodejs-repo-tools": "3.0.0",

"async": "^2.6.0",
"codecov": "^3.0.0",
"eslint": "^4.11.0",
Expand Down
Loading