Skip to content

[Snyk] Fix for 3 vulnerabilities #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashim21223445 merged 1 commit into from
Dec 11, 2025
Merged

[Snyk] Fix for 3 vulnerabilities #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
},
"dependencies": {
"@google-cloud/pubsub": "4.0.0",
"yargs": "10.1.2"
"yargs": "11.1.1"

@gemini-code-assist gemini-code-assist Bot Dec 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to yargs@11.1.1 is problematic for two reasons:

  1. Incomplete Security Fix: It fails to resolve the high-severity ReDoS vulnerability in cross-spawn (SNYK-JS-CROSSSPAWN-8303230), as it still uses a vulnerable version of that package. A higher version of yargs (e.g., 12.0.0 or newer) is required to fix this.

  2. Broken Node.js Compatibility: yargs@11.x requires Node.js v6+, which conflicts with this project's stated support for node >=4.3.2 in the engines field. This will break the samples on older Node.js versions.

This change should be rejected. A proper fix would involve upgrading yargs to a version that resolves all vulnerabilities and simultaneously updating the engines field to reflect the new Node.js requirement.

},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "3.3.0",
"ava": "^4.0.0",
"ava": "^5.3.0",

@gemini-code-assist gemini-code-assist Bot Dec 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This upgrade to ava@5.3.0 breaks compatibility with the project's stated Node.js support. ava@5.x requires Node.js ^14.18.0 || ^16.14.0 || >=18.0.0, which conflicts with the "node": ">=4.3.2" setting in the engines field.

While ava is a development dependency, this discrepancy will cause tests to fail for any developer using an older, supposedly supported, Node.js version. The engines declaration should be made consistent with the dev dependencies' requirements.

"nyc": "^15.0.0",
"proxyquire": "1.8.0",
"sinon": "4.5.0",
Expand Down
Loading