fix: use intrinsic where required instead of closure

Author: indietyp

libs/@local/hashql/mir/src/body/mod.rs

@@ -71,11 +71,11 @@ pub enum Source<'heap> {
     /// A compiler intrinsic function.
     ///
     /// This variant represents MIR generated for built-in operations that have
-    /// special compiler support or runtime behavior. The [`DefId`] identifies the intrinsic
-    /// definition.
+    /// special compiler support or runtime behavior. Intrinsics may define a fallback
+    /// implementation inside of their body.
     ///
-    /// The body of an intrinsic function is typically empty, as the intrinsic
-    /// operation is handled directly by the compiler or runtime.
+    /// Intrinsics are never inlined, but are still optimized, except in the case of explicit
+    /// opt-out.
     Intrinsic(Intrinsic),
 
     /// A compiler-synthesized wrapper that makes a non-first-class operation callable as a

libs/@local/hashql/mir/src/builder/body.rs

@@ -382,7 +382,7 @@ macro_rules! body {
         $crate::body::Source::Ctor($name)
     };
     (@source intrinsic) => {
-        $crate::body::Source::Intrinsic($crate::def::DefId::PLACEHOLDER)
+        $crate::body::Source::Intrinsic($crate::intrinsic::Intrinsic { id: $crate::intrinsic::IntrinsicId::EntityPropertyAccess, optimize: true })
     };
     (@source [synthetic $name:expr]) => {
         $crate::body::Source::Synthetic($name)

libs/@local/hashql/mir/src/intrinsic.rs

@@ -9,6 +9,14 @@ pub enum IntrinsicId {
 #[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct Intrinsic {
     pub id: IntrinsicId,
-    // Hint to any optimization passes that this intrinsic should not be optimized in any way.
+    // Hint to any optimization passes whether the intrinsic should participate in optimization, or
+    // should be skipped.
     pub optimize: bool,
 }
+
+impl Intrinsic {
+    #[must_use]
+    pub const fn new(id: IntrinsicId) -> Self {
+        Self { id, optimize: true }
+    }
+}

libs/@local/hashql/mir/src/lib.rs

@@ -45,7 +45,7 @@ pub mod def;
 pub mod error;
 pub mod intern;
 pub mod interpret;
-mod intrinsic;
+pub mod intrinsic;
 mod macros;
 pub mod pass;
 pub mod pretty;

libs/@local/hashql/mir/src/pass/transform/inline/tests.rs

@@ -27,6 +27,7 @@ use crate::{
     context::MirContext,
     def::{DefId, DefIdSlice, DefIdVec},
     intern::Interner,
+    intrinsic::{Intrinsic, IntrinsicId},
     pass::{
         Changed, GlobalTransformPass as _, OwnedGlobalTransformState,
         analysis::{CallGraph, CallSite},
@@ -542,7 +543,7 @@ fn analysis_directives_by_source() {
 
     let mut intrinsic_body = closure_body.clone();
     intrinsic_body.id = DefId::new(2);
-    intrinsic_body.source = Source::Closure(HirId::PLACEHOLDER, None);
+    intrinsic_body.source = Source::Intrinsic(Intrinsic::new(IntrinsicId::EntityPropertyAccess));
 
     // Fix closure_body id to be 0
     closure_body.id = DefId::new(0);