Skip to content

BE-592: HashQL: Remove old eval graph path and core value types #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 5 commits into
base: bm/be-590-hgraph-entity-query-request-refactor
Choose a base branch
from
Open

BE-592: HashQL: Remove old eval graph path and core value types #8841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e61b10
feat: remove read module
indietyp Jun 8, 2026
6b5027c
chore: remove everything
indietyp Jun 8, 2026
dec8c87
chore: move type-system dep
indietyp Jun 8, 2026
3dd6d9c
chore: clean up dependencies
indietyp Jun 16, 2026
3a6d593
chore: sync turborepo
indietyp Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ futures = { version = "0.3.31", default-features = fa
futures-channel = { version = "0.3.31", default-features = false }
futures-core = { version = "0.3.31", default-features = false }
futures-io = { version = "0.3.31", default-features = false }
futures-lite = { version = "2.6.1" }
futures-sink = { version = "0.3.31", default-features = false }
futures-util = { version = "0.3.31", default-features = false }
glob = { version = "0.3.3" }
Expand Down Expand Up @@ -249,6 +250,8 @@ smallvec = { version = "2.0.0-alpha.11", default-featu
smol_str = { version = "0.3.4" }
sort-package-json = { version = "0.0.12" }
specta = { version = "2.0.0-rc.22", default-features = false }
sqruff-lib = { version = "0.37.3" }
sqruff-lib-core = { version = "0.37.3" }
stacker = { version = "0.1.22", default-features = false }
supports-color = { version = "3.0.2", default-features = false }
supports-unicode = { version = "3.0.0", default-features = false }
Expand Down
5 changes: 5 additions & 0 deletions libs/@local/graph/api/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ hash-graph-store = { workspace = true, features = ["utoipa"] }
hash-graph-temporal-versioning = { workspace = true }
hash-graph-type-defs = { workspace = true }
hash-graph-validation = { workspace = true }
hashql-ast = { workspace = true }
hashql-diagnostics = { workspace = true, features = ["serde", "render"] }
hashql-eval = { workspace = true }
hashql-hir = { workspace = true }
hashql-syntax-jexpr = { workspace = true }

@cursor cursor Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused HashQL graph-api dependencies

Low Severity

This commit adds five hashql-* workspace dependencies to hash-graph-api, but nothing under libs/@local/graph/api/src references those crates. The library still builds only existing graph REST/RPC code, so the new edges pull a large HashQL compile graph without any call site in this crate.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 98ab2be. Configure here.

type-system = { workspace = true, features = ["utoipa"] }

# Private third-party dependencies (optional)
Expand Down
1 change: 1 addition & 0 deletions libs/@local/hashql/ast/src/lowering/node_renumberer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ impl Visitor<'_> for NodeRenumberer {
}

impl Default for NodeRenumberer {
#[inline]
fn default() -> Self {
Self::new()
}
Expand Down
1 change: 1 addition & 0 deletions libs/@local/hashql/ast/src/lowering/sanitizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ impl<'heap> Visitor<'heap> for Sanitizer {
}

impl Default for Sanitizer {
#[inline]
fn default() -> Self {
Self::new()
}
Expand Down
2 changes: 1 addition & 1 deletion libs/@local/hashql/compiletest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ version.workspace = true
hashql-ast = { workspace = true, public = true }
hashql-core = { workspace = true, public = true }
hashql-diagnostics = { workspace = true, features = ["render"], public = true }
hashql-eval = { workspace = true, features = ["graph"], public = true }
hashql-eval = { workspace = true, public = true }
hashql-hir = { workspace = true, public = true }
hashql-mir = { workspace = true, public = true }
hashql-syntax-jexpr = { workspace = true, public = true }
Expand Down
127 changes: 0 additions & 127 deletions libs/@local/hashql/compiletest/src/suite/eval_graph_read_entity.rs
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions libs/@local/hashql/compiletest/src/suite/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ mod ast_lowering_special_form_expander;
mod ast_lowering_type_definition_extractor;
mod ast_lowering_type_extractor;
pub(crate) mod common;
mod eval_graph_read_entity;
mod eval_postgres;
mod hir_lower_alias_replacement;
mod hir_lower_checking;
Expand Down Expand Up @@ -50,8 +49,7 @@ use self::{
ast_lowering_sanitizer::AstLoweringSanitizerSuite,
ast_lowering_special_form_expander::AstLoweringSpecialFormExpanderSuite,
ast_lowering_type_definition_extractor::AstLoweringTypeDefinitionExtractorSuite,
ast_lowering_type_extractor::AstLoweringTypeExtractorSuite,
eval_graph_read_entity::EvalGraphReadEntitySuite, eval_postgres::EvalPostgres,
ast_lowering_type_extractor::AstLoweringTypeExtractorSuite, eval_postgres::EvalPostgres,
hir_lower_alias_replacement::HirLowerAliasReplacementSuite,
hir_lower_checking::HirLowerTypeCheckingSuite, hir_lower_ctor::HirLowerCtorSuite,
hir_lower_graph_hoisting::HirLowerGraphHoistingSuite,
Expand Down Expand Up @@ -152,7 +150,6 @@ const SUITES: &[&dyn Suite] = &[
&AstLoweringSpecialFormExpanderSuite,
&AstLoweringTypeDefinitionExtractorSuite,
&AstLoweringTypeExtractorSuite,
&EvalGraphReadEntitySuite,
&EvalPostgres,
&HirLowerAliasReplacementSuite,
&HirLowerCtorSuite,
Expand Down
Loading
Loading