Fix encoding error in toResponse#4
Open
niteria wants to merge 1 commit into
Open
Conversation
The old code uses `Data.ByteString.Char8.pack` which destroys unicode. Example: ``` ghci> Data.ByteString.Char8.pack "\9679" "\207" ``` The return value of `JS.getResponseText` is overloaded to return something of type `FromJSString result => Maybe result`. There's no instance `FromJSString ByteString` in scope so the next best thing is the `Text` instance. This actually came up in my project and this patch fixed it.
Author
|
Tagging @phadej in case the notification went nowhere. |
|
This bug just caused problems for me as well. Any chance we can get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code uses
Data.ByteString.Char8.packwhich destroys unicode.Example:
The return value of
JS.getResponseTextis overloaded to return somethingof type
FromJSString result => Maybe result.There's no instance
FromJSString ByteStringin scope so the next best thingis the
Textinstance.This actually came up in my project and this patch fixed it.