Expose LookupContext#78
Open
clintonmead wants to merge 1 commit into
Open
Conversation
This is because it's exposed as part of the `HasServer` instance of `MultipartForm'`, but annoyingly one can't refer to it outside the module. To avoid adding this export to `Servant.Multipart`, I've instead created 1Servant.Multipart.Internal` and exposed it there.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to refer to
LookupContextby name in the constraints for aHasServerinstance, and found I couldn't because it's not exposed.So what I've done in this library to avoid changing the exports of the main library is:
Servant.Multipart.InternalLookupContextthere.Servant.Multipart.InternalintoServant.Multipartbut don't export it.Alternatively, if you were happy just to add
LookupContextto the export list ofServant.Multipartthat would remove the need for this PR. Whatever you prefer.