-
Notifications
You must be signed in to change notification settings - Fork 97
Text-native lexer/parser internals (closes #478) #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgajda
wants to merge
8
commits into
haskell-suite:master
Choose a base branch
from
mgajda:perf-text-lexer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e532fa1
Move parser internals and entry points to Text
mgajda b5265a6
Make lexer keyword tables and lex workers Text-native
mgajda 0e1a772
Strict tokenizer: bang discard, T.span-based lexWhileT
mgajda 7d273e6
Strict Token fields; tidy lexString/lexQQBody style
mgajda 674ff8c
Expose Text-input lexer entry points
mgajda b56c047
lexString: fast-path slice from input Text when literal has no escapes
mgajda 4146610
lexString: scan-and-splice replaces cons-list fallback
mgajda 635133f
CHANGELOG: 1.23.2 entry with measured Phase 1 numbers
mgajda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Name: haskell-src-exts | ||
| Version: 1.23.1 | ||
| Version: 1.23.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an api-breaking change, so it would need to be a bump to |
||
| License: BSD3 | ||
| License-File: LICENSE | ||
| Build-Type: Simple | ||
|
|
@@ -50,6 +50,7 @@ Library | |
| Build-Tools: happy >= 1.19 | ||
| Build-Depends: array >= 0.1, pretty >= 1.0, | ||
| base >= 4.5 && < 5, | ||
| text >= 1.2, | ||
| -- this is needed to access GHC.Generics on GHC 7.4 | ||
| ghc-prim | ||
| -- this is needed to access Data.Semigroup and Control.Monad.Fail on GHCs | ||
|
|
@@ -70,6 +71,7 @@ Library | |
| Language.Haskell.Exts.Fixity, | ||
| Language.Haskell.Exts.ExactPrint, | ||
| Language.Haskell.Exts.Parser, | ||
| Language.Haskell.Exts.Parser.Text, | ||
| Language.Haskell.Exts.Comments | ||
|
|
||
| Other-modules: Language.Haskell.Exts.ExtScheme, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for all this in the changelog; just a single bullet for what the change is, and reference the pr number for the details.