WIP: Add nub#570
Draft
sjakobi wants to merge 2 commits into
Draft
Conversation
treeowl
reviewed
Dec 5, 2025
treeowl
left a comment
treeowl
left a comment
Collaborator
There was a problem hiding this comment.
There are two situations with different needs:
- Repetitions are common. Your current code is optimized for this case.
- Repetitions are rare.
In the rare-repetition case, we almost always insert the key, so checking first seems like a waste of time. A version optimized for this would return (something isomorphic to) Maybe (HashMap k a). Since we don't have an efficient setjmp/longjmp, I believe this will be slower than your version in the common-repetition case.
Do we want two versions of the function?
| | otherwise = go h k x s $ BitmapIndexed (mask hy s) (A.singleton t) | ||
| {-# INLINABLE unsafeInsert #-} | ||
|
|
||
| unsafeInsertNewKeyM :: Hash -> k -> v -> HashMap k v -> ST s (HashMap k v) |
Collaborator
There was a problem hiding this comment.
Perhaps absent instead of new?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #560.