Remove redundant length check in sameArray1#591
Merged
Conversation
Both call sites (equal1 and equalKeys) only compare arrays whose lengths are already known to be equal: BitmapIndexed comparisons are guarded by equal bitmaps (equal popCount, hence equal array length), and Full nodes always hold maxChildren elements. Fixes #465. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
treeowl
approved these changes
Jun 4, 2026
sjakobi
marked this pull request as ready for review
June 4, 2026 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the upfront
lenxs /= lenyslength check fromsameArray1and documents a precondition that callers pass equal-length arrays.Both call sites only compare arrays already known to be equal length:
bm1 == bm2→ equal popCount → equal array length (INV4).maxChildrensub-nodes (INV8).Fixes #465.