Make lukko flag automatic and off by default#11003
Merged
mergify[bot] merged 1 commit intoJun 21, 2025
Merged
Conversation
Bodigrim
force-pushed
the
make-lukko-flag-automatic-and-false-by-default
branch
from
97562d7 to
73f8fe5
Compare
ulysses4ever
approved these changes
Jun 19, 2025
geekosaur
approved these changes
Jun 19, 2025
mergify
Bot
added
ready and waiting
The lukko package (https://hackage.haskell.org/package/lukko) was meant to be a temporary workaround, and relevant improvements have been long accessible from base:GHC.IO.Handle.Lock. As suggested at haskellari/lukko#39 (comment), let's switch the default value of the lukko flag of cabal-install from True to False. Additionally, to be on the safe side, we make it an automatic one, so that if things go terribly wrong a Hackage revision could sort it back. The same change has been implemented for the hackage-security package sometime ago in haskell/hackage-security#322, and there seems to be no complaints.
Mikolaj
force-pushed
the
make-lukko-flag-automatic-and-false-by-default
branch
from
73f8fe5 to
7d9d53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lukkopackage was meant to be a temporary workaround, and relevant improvements have been long accessible frombase:GHC.IO.Handle.Lock.As suggested at haskellari/lukko#39 (comment), let's switch the default value of the
lukkoflag ofcabal-installfromTruetoFalse. Additionally, to be on the safe side, we make it an automatic one, so that if things suddenly go terribly wrong a Hackage revision could sort it back.The same change has been implemented for the
hackage-securitypackage sometime ago in haskell/hackage-security#322, and there seems to be no complaints.Template B: This PR (hopefully) does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: