Skip to content

Don't warn on mhs-options (fixes #11341)#11344

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
sol:mhs-options
Jun 18, 2026
Merged

Don't warn on mhs-options (fixes #11341)#11344
mergify[bot] merged 1 commit into
haskell:masterfrom
sol:mhs-options

Conversation

@sol

@sol sol commented Dec 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This addresses #11341.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@geekosaur

geekosaur commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

You should have used the template and filled in the appropriate checklist.

@sol sol marked this pull request as ready for review December 13, 2025 00:26
This was referenced Dec 13, 2025
Closed
Closed
@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Dec 13, 2025
@ulysses4ever

ulysses4ever commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

Yes. I'd be great if you could restore the template by copying it from some other pr. This probably needs a changelog at least.

@ulysses4ever ulysses4ever removed the merge me Tell Mergify Bot to merge label Dec 13, 2025
@sol

sol commented Dec 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ulysses4ever I already added a changelog entry. I think the other things from the list did not apply.

I'll keep the template in the future and tick the things that apply.

@sol sol added the merge me Tell Mergify Bot to merge label Dec 13, 2025
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 13, 2025
@sol

sol commented Dec 13, 2025

Copy link
Copy Markdown
Member Author

Do I need to take any action regarding the failing Windows binary release build (zip: command not found)?

@ulysses4ever

ulysses4ever commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

@sol no. Sorry for the confusion.

@geekosaur

geekosaur commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

You know, I think we might need a Hackage maintainer to rule on whether this actually needs to be a file format change, since it impacts what Hackage accepts. @phadej?

@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Dec 15, 2025
@mergify

mergify Bot commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at ec10df6

This pull request spent 1 hour 23 minutes 43 seconds in the queue, including 1 hour 13 minutes 8 seconds running CI.
The checks were run on draft #11348.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify Bot added a commit that referenced this pull request Dec 15, 2025
@mergify
Merge of #11344
b62c0d3
@mergify mergify Bot mentioned this pull request Dec 15, 2025
Closed
86 tasks
@mergify mergify Bot added dequeued and removed queued labels Dec 15, 2025
@geekosaur

geekosaur commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

@Mergifyio rebase

@mergify

mergify Bot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@mergify mergify Bot removed the dequeued label Dec 15, 2025
@Mikolaj

Mikolaj commented Dec 15, 2025

Copy link
Copy Markdown
Member

You know, I think we might need a Hackage maintainer to rule on whether this actually needs to be a file format change, since it impacts what Hackage accepts. @phadej?

In that case, let's wait with the merging. @gbaz: what do you think?

Mikolaj
Mikolaj previously requested changes Dec 15, 2025
View reviewed changes

@Mikolaj Mikolaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until hackage-server maintainers recommend whether this should be a file format change. BTW, where do I look up who the maintainers are?

@Mikolaj

Mikolaj commented Dec 18, 2025

Copy link
Copy Markdown
Member

@mpickering: from your long cabal dev experience, would you have any advice about this one?

@Mikolaj Mikolaj removed merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Dec 29, 2025
@geekosaur

geekosaur commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator

Sigh. So the answer to my question is that this does inpact Hackage… because Hackage uses cabal to validate cabal files, meaning that a cabal that only considers GHC a first class compiler is a gatekeeper for Hackage that keeps it GHC-only in practice.

@mergify

mergify Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

rebase

🛑 The pull request rule doesn't match anymore

Details

This action has been cancelled.

@sol sol added merge me Tell Mergify Bot to merge attention: needs-backport 3.18 labels Jun 16, 2026
@sol

sol commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Thanks @geekosaur. I added the "merge me" label.

@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jun 16, 2026
@mergify

mergify Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 47 minutes 21 seconds in the queue, including 1 hour 35 minutes 44 seconds running CI.

Waiting for any of
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify Bot added a commit that referenced this pull request Jun 18, 2026
@mergify
Merge of #11344
0f359f3
@mergify mergify Bot mentioned this pull request Jun 18, 2026
Closed
84 tasks
@mergify mergify Bot added dequeued and removed queued labels Jun 18, 2026
@mergify mergify Bot added queued and removed dequeued labels Jun 18, 2026
@mergify

mergify Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-18 22:10 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-06-18 22:21 UTC · at 31acbf07a09c272e32625b48f2721db2801277d5 · merge

This pull request spent 11 minutes 6 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify Bot merged commit 7d5e438 into haskell:master Jun 18, 2026
83 of 85 checks passed
@mergify mergify Bot removed the queued label Jun 18, 2026
@sol sol deleted the mhs-options branch June 19, 2026 02:22
@ulysses4ever

ulysses4ever commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

@mergify backport 3.18

@mergify

mergify Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport 3.18

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Jun 19, 2026
Merged
6 tasks
mergify Bot added a commit that referenced this pull request Jun 19, 2026
@mergify
Merge pull request #11986 from haskell/mergify/bp/3.18/pr-11344
88d4b30 
Backport #11344: Don't warn on `mhs-options` (fixes #11341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekosaur geekosaur geekosaur approved these changes
@ulysses4ever ulysses4ever ulysses4ever approved these changes
@Mikolaj Mikolaj Mikolaj left review comments

Assignees

No one assigned

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sol @geekosaur @ulysses4ever @Mikolaj @ffaf1