Init CLI flag documentation improvement#11721
Init CLI flag documentation improvement#11721emilypi wants to merge 9 commits intohaskell:masterfrom
Conversation
ulysses4ever
left a comment
There was a problem hiding this comment.
I think shoving more stuff in the --help isn't very helpful (although isn't harmful either, so I approve). My impression from that issue thread was that the agreement was that it's the interactive mode who should advertislze the other mode in the very beginning.
cc @AndreasPK
geekosaur
left a comment
There was a problem hiding this comment.
I'm neutral on this, FWIW, and agree that we should consider splitting functionality at some point as something more useful than just adjusting help text.
I will note that some programs (notably most of Larry Wall's: original patch, rn, etc.) output their manpages for --help. (But not Perl, because it's a full language and there's like 30 of them at this point and were at least 10 at the original public release.) That's probably overkill, though.
|
At the very least, the documentation was stale, so this brings it up to par before we branch off or do whatever. |
|
Emily, I should have said first that I appreciate your effort before jumping into the negative part. I apologize! I didn't notice any fixes per se: I thought this patch was purely additive. But I see it now: the part about supplying the root of the project was removed. Thanks! But since you mentioned documentation, I think these days (and especially due to the AI storm) the online docs are much more important than |
|
I actually don't know how to modify the readthedocs site fwiw - point me at the repo and I'm sure I'll survive. I can add it to the PR. I don't mind criticism btw - we're in subjective territory here |
…al into emily/init-docs-improvements
|
@ulysses4ever thanks! updated. |
|
Great! The formatting and whitespace jobs are failing which is the last thing that needs fixing before the merge bot can take it. |
|
@ulysses4ever should be fixed now. Nice tool btw |
|
formatting seems unhappy again, I'm sorry! We use fourmolu-0.12.0.0. An older version always bites people... also, you can apply a merge label when you're happy with it. The squash label is appropriate here perhaps. |
…al into emily/init-docs-improvements
|
I'm a fan of the new checks! |
Merge Queue Status
This pull request spent 1 hour 40 minutes 55 seconds in the queue, including 1 hour 30 minutes 40 seconds running CI. Waiting for any of:
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
See @Mikolaj's comment. The existing docs are there for anyone who issues
--help, but it's non-obvious to Haskell developers that they may need help, so this creates a natural conflict.