[WIP] Avoid sharing shallow SRP references#11921
Draft
ulysses4ever wants to merge 4 commits into
Draft
Conversation
Separate git source-repository-package reference peers by branch/tag so a shallow checkout is never reused as a reference for a different target ref. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
The test was using 'base >=4.14 && <5' which excluded GHC 8.8.4 that ships with base-4.13. Since the test doesn't require any specific base features, we can just use 'base' without version constraints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The test now uses actual files in upstream-repo/ and dummy-app/ directories, making it much easier to read and understand. The test copies these template files into the git repo during setup. Benefits: - Physical files are easier to edit and review - Test code is shorter and clearer - File structure is visible in the repository Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Rename upstream-repo/ to repo-template/ for clarity - Fix issue reference to point to actual PR comment - Add comments explaining why we need copyFileToDir and writeSourceFile - Clarify that cabal.project must be generated dynamically for commit hashes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i am looking into how to design a test
Separate git source-repository-package reference peers by branch/tag so a shallow checkout is never reused as a reference for a different target ref.
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.