Skip to content

Use SPECIALIZE consistently #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meooow25 merged 3 commits into from
May 23, 2026
+8 −8
Merged

Use SPECIALIZE consistently #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d1add6
Use `SPECIALIZE` consistently
sol May 16, 2026
affc8d3
Use specialized consistently
sol May 16, 2026
807bd82
Update Internal.hs
sol May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion containers/src/Data/Map/Internal.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4311,7 +4311,7 @@ balance_ k x l r = case l of
(_, _) -> error "Failure in Data.Map.balance"
{-# NOINLINE balance_ #-}

-- Functions balanceL and balanceR are specialised versions of balance.
-- Functions balanceL and balanceR are specialized versions of balance.
-- balanceL only checks whether the left subtree is too big,
-- balanceR only checks whether the right subtree is too big.

Expand Down
12 changes: 6 additions & 6 deletions containers/src/Data/Sequence/Internal/Sorting.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ foldToMaybeWithIndexTree :: (b -> b -> b)
-> Maybe b
foldToMaybeWithIndexTree = foldToMaybeWithIndexTree'
where
{-# SPECIALISE foldToMaybeWithIndexTree' :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> FingerTree (Elem y) -> Maybe b #-}
{-# SPECIALISE foldToMaybeWithIndexTree' :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> FingerTree (Node y) -> Maybe b #-}
{-# SPECIALIZE foldToMaybeWithIndexTree' :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> FingerTree (Elem y) -> Maybe b #-}
{-# SPECIALIZE foldToMaybeWithIndexTree' :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> FingerTree (Node y) -> Maybe b #-}
foldToMaybeWithIndexTree'
:: Sized a
=> (b -> b -> b) -> (Int -> a -> b) -> Int -> FingerTree a -> Maybe b
Expand All @@ -422,14 +422,14 @@ foldToMaybeWithIndexTree = foldToMaybeWithIndexTree'
m' = foldToMaybeWithIndexTree' (<+>) (node (<+>) f) sPspr m
!sPspr = s + size pr
!sPsprm = sPspr + size m
{-# SPECIALISE digit :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> Digit (Elem y) -> b #-}
{-# SPECIALISE digit :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> Digit (Node y) -> b #-}
{-# SPECIALIZE digit :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> Digit (Elem y) -> b #-}
{-# SPECIALIZE digit :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> Digit (Node y) -> b #-}
digit
:: Sized a
=> (b -> b -> b) -> (Int -> a -> b) -> Int -> Digit a -> b
digit = foldWithIndexDigit
{-# SPECIALISE node :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> Node (Elem y) -> b #-}
{-# SPECIALISE node :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> Node (Node y) -> b #-}
{-# SPECIALIZE node :: (b -> b -> b) -> (Int -> Elem y -> b) -> Int -> Node (Elem y) -> b #-}
{-# SPECIALIZE node :: (b -> b -> b) -> (Int -> Node y -> b) -> Int -> Node (Node y) -> b #-}
node
:: Sized a
=> (b -> b -> b) -> (Int -> a -> b) -> Int -> Node a -> b
Expand Down
2 changes: 1 addition & 1 deletion containers/src/Data/Set/Internal.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,7 +1957,7 @@ ratio = 2
-- Only balanceL and balanceR are needed at the moment, so balance is not here anymore.
-- In case it is needed, it can be found in Data.Map.

-- Functions balanceL and balanceR are specialised versions of balance.
-- Functions balanceL and balanceR are specialized versions of balance.
-- balanceL only checks whether the left subtree is too big,
-- balanceR only checks whether the right subtree is too big.

Expand Down
Loading