Skip to content

refactor!: store log files under XDG_STATE_HOME instead of XDG_CACHE_HOME when following XDG style #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hasufell merged 2 commits into from
May 15, 2026
Merged

refactor!: store log files under XDG_STATE_HOME instead of XDG_CACHE_HOME when following XDG style #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd48491
fix: modify message to indicate log file location when following XDG …
e-kwsm Apr 3, 2026
db260a0
refactor!: store log files under XDG_STATE_HOME instead of XDG_CACHE_…
e-kwsm Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib-tui/GHCup/Brick/Actions.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ installWithOptions opts (_, ListResult {..}) = do
VLeft (V (AlreadyInstalled _ _)) -> pure $ Right ()
VLeft (V NoUpdate) -> pure $ Right ()
VLeft e -> pure $ Left $ prettyHFError e <> "\n"
<> "Also check the logs in ~/.ghcup/logs"
<> "Also check the logs in ~/.ghcup/logs or $XDG_STATE_HOME/ghcup/logs"

install' :: (MonadReader AppState m, MonadIO m, MonadThrow m, MonadFail m, MonadMask m, MonadUnliftIO m, Alternative m)
=> (Int, ListResult) -> m (Either String ())
Expand Down
6 changes: 3 additions & 3 deletions lib/GHCup/Query/GHCupDirs.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,19 +232,19 @@ ghcupCacheDir
-- | Defaults to '~/.ghcup/logs'.
--
-- If 'GHCUP_USE_XDG_DIRS' is set (to anything),
-- then uses 'XDG_CACHE_HOME/ghcup/logs' as per xdg spec.
-- then uses 'XDG_STATE_HOME/ghcup/logs' as per xdg spec.
ghcupLogsDir :: IO GHCupPath
ghcupLogsDir
| isWindows = ghcupBaseDir <&> (\(GHCupPath gp) -> GHCupPath (gp </> "logs"))
| otherwise = do
xdg <- useXDG
if xdg
then do
bdir <- lookupEnv "XDG_CACHE_HOME" >>= \case
bdir <- lookupEnv "XDG_STATE_HOME" >>= \case
Just r -> pure r
Nothing -> do
home <- liftIO getHomeDirectory
pure (home </> ".cache")
pure (home </> ".local" </> "state")
pure (GHCupPath (bdir </> "ghcup" </> "logs"))
else ghcupBaseDir <&> (\(GHCupPath gp) -> GHCupPath (gp </> "logs"))

Expand Down