Skip to content

Commit e4f1711

Browse files
soulomoonfendor
andauthored
Apply suggestions from code review
Co-authored-by: fendor <fendor@users.noreply.github.com>
1 parent b599ae9 commit e4f1711

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/bench.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@ jobs:
2727
# since benchmark are expansive.
2828
# choosing the two latest are easier to maintain and more forward looking
2929
# see discussion https://github.com/haskell/haskell-language-server/pull/4118
30-
# also possible to add more GHCs if we performs better in the future.
30+
# Benchmarking only the two latest GHCs we support now
31+
# since benchmark are expensive.
32+
# Choosing the two latest is easier to maintain and more forward looking.
33+
# See discussion https://github.com/haskell/haskell-language-server/pull/4118
34+
# also possible to add more GHCs if we perform better in the future.
3135
echo 'versions=["9.12", "9.14"]' >> $GITHUB_OUTPUT
3236
- id: skip_check
3337
uses: fkirc/skip-duplicate-actions@v5.3.1

cabal.project

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ constraints:
5151
allow-newer:
5252
cabal-install-parsers:Cabal-syntax,
5353

54-
if impl(ghc >= 9.15)
55-
benchmarks: False
5654

5755
if impl(ghc >= 9.13)
5856
allow-newer:

shake-bench/shake-bench.cabal

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ source-repository head
1616
location: https://github.com/haskell/haskell-language-server.git
1717

1818
library
19-
if impl(ghc >= 9.15)
20-
buildable: False
2119
exposed-modules: Development.Benchmark.Rules
2220
hs-source-dirs: src
2321
build-depends:

0 commit comments

Comments
 (0)