Fixbench#4928
Merged
Merged
Conversation
soulomoon
added
CI
fendor
approved these changes
May 8, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
This looks good to me, but can you explain from a high level view what has changed now? Are we no longer generating the visualisations for the memory usage?
| hs-source-dirs: bench | ||
| build-tool-depends: | ||
| haskell-language-server:ghcide-bench, | ||
| eventlog2html:eventlog2html, |
Collaborator
There was a problem hiding this comment.
Are we not using eventlog2html anymore to generate the graphs?
Collaborator
Author
There was a problem hiding this comment.
profiled runs still emit raw .hp, we are just not generate the graphs so we can decouple from its deps.
Co-authored-by: fendor <fendor@users.noreply.github.com>
Collaborator
Author
|
Three things have been done.
The benchmark actually been broken for the 9.12 for a couple of months for the target repo lsp. So instead of leaving the benchmark stale and no one actually use it and no one pay attention to it. We leave just enough functionalities for our CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4929