Create hls-export-plugin with Export '...' code action#4952
Open
crtschin wants to merge 9 commits into
Open
Conversation
crtschin
force-pushed
the
crtschin/export-1-export
branch
from
9d4dfd2 to
764ce31
Compare
A shared library lets the export plugin reuse them without depending on hls-refactor-plugin.
Offered on `-Wunused-top-binds` diagnostics.
The hls-export-plugin Export action replaces it.
crtschin
force-pushed
the
crtschin/export-1-export
branch
from
a81bce2 to
418edd5
Compare
Freshly built names carry EpAnnNotUsed before GHC 9.9, so addParens could not parenthesize operators.
TcRnUnusedName gained structured provenance only in GHC 9.8, so 9.6 cannot identify unused top-level binds to attach the action to.
crtschin
force-pushed
the
crtschin/export-1-export
branch
from
418edd5 to
e9a5ab3
Compare
Contributor
|
I've tried this PR with GHC for #4967. This PR indeed fixes the invalid syntax problem, but unfortunately it does expand CPP macros in the export list. That file uses this macro in its export list: |
Collaborator
Author
Thanks for testing this out! That's an interesting wrinkle, I believe HLS generally works with post-preprocessor sources. So I'd have to build something to specifically work with preprocessor directives. I won't do that here, as the PR is already quite large, but I'll note it in #4948. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part to #4948.
This differs from the existing action that
hls-refactor-pluginprovided:hls-refactor-pluginonly worked when the symbol was detected unused.