Goto dependency #4973
Open
vidit-od wants to merge 14 commits into
Open
Conversation
Extracts Haskell source from HIE files of the third-party dependency and writes them to dependencies folder. also creates entry in hiedb pointing to this source. Mark these files as read-only. when goto dependency on third party is triggered, URI of these source is expected to be returned
Add dependency HIE indexing support for goto-definition. Construct package-to-module mappings from direct and transitive dependencies and index their HIE files into HieDb. Add cleanup for stale dependency source mappings and introduce HieFileCheck/checkHieFile for centralized HIE validation.
add support for indexing dependency HIE files in addition to project files. Allows indexing files without real source paths using FakeFile support.
makes sure that the Dependency file indexing logic actually triggers. also fixes cyclic dependencies by modularising HieFile related code to IDE.Core.HieFile
Added a new FromDependency file type and a ReadOnly rule type for files inside .hls/dependencies/ Files are now split into files (all files) and projectFiles (excluding read-only dependency files). GenerateCore and NonLocalCompletions now run only for project files, while GetHieAst runs for all files.
vidit-od
requested review from
0rphee,
July541,
drsooch,
eddiemundo,
fendor,
georgefst,
jian-lin,
joyfulmantis,
jvanbruegge,
kokobd,
konn,
michaelpj,
ozkutuk,
santiweight,
soulomoon and
wz1000
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains work for Goto dependency definition, part of GSoC' 26.
Aims to extend support for Goto-dependency-definition feature for external dependencies.
Credits :
Thank you !