new conf design — cfp#13
Closed
hasparus wants to merge 7 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hasparus
commented
May 1, 2025
Comment on lines
+375
to
+396
| <div | ||
| role="tablist" | ||
| className="flex divide-sec-dark border-b border-sec-dark *:flex-1 max-md:sr-only md:divide-x" | ||
| > | ||
| {tabsInOrder.map((tab, i) => ( | ||
| <TabButton | ||
| tab={tab} | ||
| tabIndex={i === 0 ? 0 : -1} | ||
| activeTab={activeTab} | ||
| setActiveTab={setActiveTab} | ||
| /> | ||
| ))} | ||
| </div> | ||
| <div className="flex flex-1 justify-center overflow-hidden max-md:flex-col md:items-center"> | ||
| {tabsInOrder.map(tab => ( | ||
| <> | ||
| <TabButton | ||
| tab={tab} | ||
| activeTab={activeTab} | ||
| setActiveTab={setActiveTab} | ||
| className="md:hidden" | ||
| aria-hidden | ||
| /> |
Owner
Author
There was a problem hiding this comment.
tabs are twice in the DOM, once in a tablist for desktop and screen readers, and the second time for mobiles (aria-hidden) to make it look like an accordion
hasparus
force-pushed
the
new-conf-design--cfp
branch
from
cf89863 to
e6c9e43
Compare
This was referenced May 15, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2025
Closed
This was referenced May 15, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm not 100% sure about the text sections in here and dark mode variant is TBD.