fix: only keep v1_step_concurrency active when it has work#3629
Open
fix: only keep v1_step_concurrency active when it has work#3629
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grutt
requested review from
abelanger5,
mnafees and
mrkaye97
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CheckStrategyActive was keeping any strategy on the latest workflow version pinned is_active=true regardless of whether any tasks were queued or running. This caused active strategy counts to grow with every deployment, each spinning up a ConcurrencyManager that polled Postgres every 500ms-5s. Strategies are now deactivated when idle and re-activated by the after_v1_concurrency_slot_insert trigger when new
work arrives.
In simpler words, v1_step_concurrency is deactivated if no future work exist.
Type of change