fix: clamp set interval guage to max interval#3954
Open
grutt wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grutt
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential time.Duration overflow in the interval backoff logic that could cause the interval to wrap around (becoming negative/small) and lead to unexpectedly long or erratic scheduling delays.
Changes:
- Clamp
currIntervaltomaxIntervalbefore doubling would overflow/exceed the maximum. - Add a unit test to validate that the interval caps at
maxIntervalinstead of overflowing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/operation/interval.go | Prevents overflow by capping currInterval at maxInterval when doubling would exceed it. |
| internal/operation/interval_test.go | Adds a regression test ensuring the cap happens before an overflow can occur. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents wraparoudn which could lead to signifcant scheduling delays
Type of change