Fix: Only run worker id action getter query when needed#3976
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
abelanger5
approved these changes
May 20, 2026
grutt
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the worker repository’s action lookup to avoid querying GetWorkerActionsByWorkerId when there are no worker IDs to look up, and adds tracing to help debug action-resolution behavior in the worker listing/get paths.
Changes:
- Add an OTel span around
WorkerRepository.GetWorkerActionsForWorkersand attach debugging attributes. - Only call
GetWorkerActionsByWorkerIdwhenworkerIdsis non-empty. - Refactor action mapping logic to build the result map from action-hash lookups first, then worker-id lookups.
Comment on lines
+321
to
+326
| if len(recordsFromActionHashes) > 0 { | ||
| for _, record := range recordsFromActionHashes { | ||
| workerIds, ok := actionHashToWorkerIds[string(record.ActionHash)] | ||
|
|
||
| workerIdToActionIds := make(map[string][]string) | ||
| if !ok { | ||
| continue |
grutt
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only running
GetWorkerActionsByWorkerIdwhen needed (when there are worker ids). Also added another span and some attributes for debugging here.Type of change
Checklist
Changes have been:
🤖 AI Disclosure
There was no LLM use in this PR