chore: use external quickstarts module#4236
Merged
gregfurman merged 2 commits intoJun 25, 2026
Merged
Conversation
Update hatchet-cli to load quickstart templates from the github.com/hatchet-dev/hatchet-quickstarts module instead of embedding the local template tree. Removes the cli templates source and stale e2e workflow path filters for the deleted template tree. Refs hatchet-dev#4107.
|
@BloggerBust is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
github_actions
Collaborator
|
Just realised this is going to upset dependabot since it'll no longer find these quickstart subdirs 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is Phase 3 of #4107, which moves the quickstart templates into a dedicated module so they can be versioned and released on their own. hatchet-cli now loads quickstart templates from the
github.com/hatchet-dev/hatchet-quickstartsmodule atv0.1.0instead of embedding the localcmd/hatchet-cli/cli/templates/tree.Refs #4107. Completes Phase 3
Type of change
What's Changed
quickstart.goloads templates viaquickstarts.TemplatesFS()from the external module, replacing the embeddedcontentfilesystem and the//go:embed all:templates/*declaration.github.com/hatchet-dev/hatchet-quickstarts v0.1.0togo.modandgo.sumas a direct dependency, with noreplace.cmd/hatchet-cli/cli/templates/tree.cmd/hatchet-cli/cli/templates/**entries from.github/workflows/cli-e2e-tests.yml, under bothpull_requestandpush.Checklist
Changes have been:
Testing
Validated locally:
go build ./cmd/hatchet-cli/...go test ./cmd/hatchet-cli/cli/internal/templater/... ./cmd/hatchet-cli/cli/...go test -tags e2e_cli -run TestQuickstartTemplates -count=0 ./cmd/hatchet-cli/cli/(compiles the e2e target)go test ./cmd/hatchet-cli/...go vet ./cmd/hatchet-cli/cli/...,gofmt, andgo mod tidywith no resulting changes🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Claude code was used for review and validation.