chore: only err RMQ retries when over 80% mark#4270
Open
mnafees wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy RabbitMQ retry logging by downgrading most retry logs from Error to Warn, only escalating to Error when the retry/death count is near the configured maximum.
Changes:
- Introduces a
loggerthat defaults toWarn()and switches toError()once the message retry count crosses an 80% threshold ofmaxDeathCount. - Keeps the existing “only log after 5 retries” gate, but changes the severity level when logging does occur.
Contributor
Benchmark resultsCompared against |
mrkaye97
approved these changes
Jun 29, 2026
| deadLetterBackoff: 5 * time.Second, | ||
| enableMessageRejection: false, | ||
| maxDeathCount: 5, | ||
| maxDeathCount: 1000, |
Contributor
There was a problem hiding this comment.
I'm not too sure we want to change this default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to get rid of noisy errors. This PR adjusts how we error out RMQ errors.
Type of change
What's Changed
Checklist
Changes have been:
🤖 AI Disclosure