Skip to content

chore: only err RMQ retries when over 80% mark #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mnafees wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: only err RMQ retries when over 80% mark #4270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933beb4
only err rmq retries when over 80% mark
mnafees Jun 24, 2026
18da0c9
adhere to default max death count config value
mnafees Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/msgqueue/rabbitmq/rabbitmq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func defaultMessageQueueImplOpts() *MessageQueueImplOpts {
disableTenantExchangePubs: false,
deadLetterBackoff: 5 * time.Second,
enableMessageRejection: false,
maxDeathCount: 5,
maxDeathCount: 1000,

@mrkaye97 mrkaye97 Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure we want to change this default?

}
}

Expand Down Expand Up @@ -804,8 +804,14 @@ func (t *MessageQueueImpl) subscribe(
// message was rejected before
deathCount := xDeath[0].(amqp.Table)["count"].(int64)

logger := t.l.Warn()
if deathCount > int64(float64(t.maxDeathCount)*0.8) {
// only log as error if we've exceeded 80% of the max death count
logger = t.l.Error()
}
Comment thread
mnafees marked this conversation as resolved.

if deathCount > 5 {
t.l.Error().
logger.
Int64("death_count", deathCount).
Str("message_id", msg.ID).
Str("tenant_id", msg.TenantID.String()).
Expand Down
Loading