require existing session for imgsrv#231
Draft
aelkiss wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the logic that requires sessions in downloads to the rest of the imgsrv routes. Annoyingly, they all handle "restricted" somewhat differently. It also removes the undocumented, unused "XYZZY" env var.
Right now, the perl tests for imgsrv fail, because they don't set up a session in the test context. This implies that we can likely set up more comprehensive tests on the perl side that cover this rather than needing to test exhaustively with the slower playwright tests.
Next step is to see about fixing the perl tests and getting more comprehensive testing in place for authentication with all imgsrv routes there.