Skip to content

Disabled Edit Round button when round is active and added entries in i18n #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SSpirate11 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disabled Edit Round button when round is active and added entries in i18n #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions frontend/src/components/Round/RoundView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,17 @@
</p>
</div>
<div style="margin-left: auto">
<cdx-button @click="toggleEditing()">
<cog style="font-size: 6px" v-if="!isRoundEditing" />
<close style="font-size: 6px" v-else />
{{ isRoundEditing ? $t('montage-btn-cancel') : $t('montage-round-edit') }}
</cdx-button>
<span
v-tooltip="
round.status === 'active' ? $t('montage-round-edit-active-warning') : undefined
"
>
<cdx-button :disabled="round.status === 'active'" @click="toggleEditing()">
<cog style="font-size: 6px" v-if="!isRoundEditing" />
<close style="font-size: 6px" v-else />
{{ isRoundEditing ? $t('montage-btn-cancel') : $t('montage-round-edit') }}
</cdx-button>
</span>
</div>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"montage-round-file-setting": "Round file settings",
"montage-round-delete": "Delete round",
"montage-round-edit": "Edit round",
"montage-round-edit-active-warning": "Please pause the round to make edits.",
"montage-round-save": "Save Round",
"montage-round-delete-confirm": "Are you sure you want to delete this round?",
"montage-round-allowed-filetypes": "Allowed filetypes",
Expand Down
1 change: 1 addition & 0 deletions frontend/src/i18n/qqq.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
"montage-round-file-setting": "Label for the file settings in a round.",
"montage-round-delete": "Label for the action to delete a round.",
"montage-round-edit": "Label for the action to edit a round.",
"montage-round-edit-active-warning": "Tooltip shown on the disabled edit button explaining that an active round must be paused before it can be edited.",
"montage-round-save": "Label for the action to save changes to a round.",
"montage-round-delete-confirm": "Confirmation message for deleting a round.",
"montage-round-allowed-filetypes": "Label for the allowed file types setting in a round.",
Expand Down
Loading