Split Email and API Token into separate settings fields#12
Merged
Conversation
Adds an Email field alongside API Token in the settings panel, plus a hyperlink to id.atlassian.com for creating a token. The auth-header builder combines them as email:token for Cloud, or sends the token alone for Server / Data Center. For backwards compatibility, an existing email:token value pasted in the API Token field continues to work when Email is empty. Bumps plugin.json to 1.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
email:prefix.email:tokenpasted into the Token field still works when Email is empty.plugin.jsonto1.2.0.Auth-header construction extracted into
AuthHeaderBuilderwith unit tests covering all three modes (separate fields, legacy combined, token-only on-prem).Test plan
dotnet testcannot satisfy the net9 apphost; CI with .NET 9 SDK runsAuthHeaderBuilderTestnormally).https://confdg.atlassian.net/wiki/rest/api/search?cql=type=page&limit=1:email:tokenin Token field) → HTTP 200