Skip to content

Commit 1bdf253

Browse files
committed
Set itemShapeFillColor for Dracula nav drawer
On-device logcat showed a recoverable ResourcesCompat warning: the NavigationView's @color/navigation_item ColorStateList self-references ?itemShapeFillColor, which the base theme never sets (only the Black theme does). Set it on the Dracula day and night styles so the selected nav-drawer item gets a proper Dracula-purple fill and the warning no longer fires. Pre-existing on all non-Black themes; fixed here for the new Dracula theme. Verified on Android: warning count 0, no crash.
1 parent bb9cda4 commit 1bdf253

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

app/src/main/res/values-night/themes.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<item name="android:colorBackground">@color/dracula_background</item>
2727
<item name="colorOnBackground">@color/dracula_on_surface</item>
2828
<item name="android:windowBackground">@color/dracula_background</item>
29+
<item name="itemShapeFillColor">@color/color_dracula</item>
2930
</style>
3031

3132
<style name="Theme.SagerNet.Dialog.Dracula" parent="Theme.SagerNet.Dialog">
@@ -40,5 +41,6 @@
4041
<item name="colorOnSurface">@color/dracula_on_surface</item>
4142
<item name="android:colorBackground">@color/dracula_background</item>
4243
<item name="colorOnBackground">@color/dracula_on_surface</item>
44+
<item name="itemShapeFillColor">@color/color_dracula</item>
4345
</style>
4446
</resources>

app/src/main/res/values/themes.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,9 @@
606606
<item name="colorMaterial100">@color/color_dracula_100</item>
607607
<item name="colorMaterial300">@color/color_dracula_300</item>
608608
<item name="cardElevatedSurfaceColor">@color/card_elevated_dracula</item>
609+
<!-- Nav drawer selected-item fill; also satisfies the ?itemShapeFillColor
610+
self-reference in @color/navigation_item. -->
611+
<item name="itemShapeFillColor">@color/color_dracula</item>
609612
</style>
610613

611614
<style name="Theme.SagerNet.Dialog.Black" parent="Theme.SagerNet.Dialog">
@@ -642,6 +645,7 @@
642645
<item name="colorMaterial100">@color/color_dracula_100</item>
643646
<item name="colorMaterial300">@color/color_dracula_300</item>
644647
<item name="cardElevatedSurfaceColor">@color/card_elevated_dracula</item>
648+
<item name="itemShapeFillColor">@color/color_dracula</item>
645649
</style>
646650

647651
<style name="Theme.Start" parent="Theme.MaterialComponents.DayNight">

0 commit comments

Comments
 (0)