Skip to content

Commit 5e2876c

Browse files
committed
fix: type DNS sanitizing listeners
1 parent 3498fef commit 5e2876c

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

app/src/main/java/io/nekohasekai/sagernet/ui/SettingsPreferenceFragment.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,11 @@ class SettingsPreferenceFragment : PreferenceFragmentCompat() {
4747
}
4848
}
4949

50-
private fun dnsReloadListener(preference: Preference, newValue: Any?): Boolean {
50+
private fun dnsReloadListener(preference: EditTextPreference, newValue: Any?): Boolean {
5151
val rawValue = newValue as? String ?: return reloadListener.onPreferenceChange(preference, newValue)
5252
val sanitizedValue = sanitizeDnsPreferenceValue(rawValue)
5353
if (sanitizedValue != rawValue) {
54-
if (preference is EditTextPreference) {
55-
preference.text = sanitizedValue
56-
}
54+
preference.text = sanitizedValue
5755
needReload()
5856
return false
5957
}
@@ -223,11 +221,11 @@ class SettingsPreferenceFragment : PreferenceFragmentCompat() {
223221
concurrentDial.onPreferenceChangeListener = reloadListener
224222

225223
enableFakeDns.onPreferenceChangeListener = reloadListener
226-
remoteDns.onPreferenceChangeListener = Preference.OnPreferenceChangeListener { preference, newValue ->
227-
dnsReloadListener(preference, newValue)
224+
remoteDns.onPreferenceChangeListener = Preference.OnPreferenceChangeListener { _, newValue ->
225+
dnsReloadListener(remoteDns, newValue)
228226
}
229-
directDns.onPreferenceChangeListener = Preference.OnPreferenceChangeListener { preference, newValue ->
230-
dnsReloadListener(preference, newValue)
227+
directDns.onPreferenceChangeListener = Preference.OnPreferenceChangeListener { _, newValue ->
228+
dnsReloadListener(directDns, newValue)
231229
}
232230
enableDnsRouting.onPreferenceChangeListener = reloadListener
233231

0 commit comments

Comments
 (0)