Skip to content

Commit e903c58

Browse files
committed
docs: commit to isolated Go 1.25 setup for MasterDnsVPN build job
Resolve the open Go-version question: use a separate setup-go scoped to the MasterDnsVPN build job rather than raising the repo-wide pin, keeping libcore's deliberate 1.24.9 toolchain alignment untouched.
1 parent 5f117d1 commit e903c58

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

docs/maintenance/masterdnsvpn-deferral.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,14 @@ Full feature scaffolding, gated to NekoBox proxy mode (no TUN, so no VPN loop):
5151
`127.0.0.1:<allocated port>`; sing-box `socks` outbound -> that port.
5252
- Bundled binaries: cross-compile `cmd/client` for all 4 ABIs into
5353
`app/executableSo/<abi>/libmasterdnsvpn.so`, built in CI (mirror `buildScript/lib/mieru.sh`
54-
and the per-workflow Mieru job). Note: MasterDnsVPN is `go 1.25.0`; the build job would
55-
need a Go that satisfies that (CI currently pins 1.24.9 for libcore — use a separate Go
56-
setup for this binary or revisit the toolchain).
54+
and the per-workflow Mieru job).
55+
- **Go toolchain decision:** MasterDnsVPN requires `go 1.25.0`, while libcore's CI is
56+
pinned to `1.24.9` (matching `libcore/go.mod`'s `toolchain` directive). Use a **separate
57+
Go setup step scoped to the MasterDnsVPN build job** (its own `actions/setup-go` with
58+
`go-version: '1.25.x'`), leaving the libcore toolchain pin untouched. Do **not** raise the
59+
whole-repo Go pin just for this binary — libcore is reproducibility-sensitive and was
60+
aligned to 1.24.9 deliberately. The MasterDnsVPN build is an independent native binary, so
61+
an isolated newer Go for that one job is the lower-risk choice.
5762
- In VPN mode, disable the profile with a clear message:
5863
"MasterDnsVPN requires Android socket protection for VPN mode. Proxy mode is supported;
5964
VPN mode will be enabled after upstream resolver sockets can be protected."

0 commit comments

Comments
 (0)