build: upgrade Go toolchain to 1.26.4 project-wide#14
Conversation
Bump libcore/go.mod toolchain directive (go1.24.9 -> go1.26.4) and all CI setup-go pins (1.24.9 -> 1.26.4). The go.mod language floor (go 1.24.7) is left as-is. Verified the native core (starifly/sing-box + libneko + gomobile + all deps) builds cleanly under Go 1.26.4 on the Linux builder.
|
Warning Review limit reached
More reviews will be available in 6 hours, 51 minutes, and 33 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
|
@coderabbitai full review Please focus on Go toolchain reproducibility. Verify this only bumps the go.mod toolchain directive and CI setup-go pins to 1.26.4 (language floor go 1.24.7 unchanged), with no source/dependency changes. The native core (starifly/sing-box + libneko + gomobile) was verified to build cleanly under Go 1.26.4 on the builder, plus a full assembleOssDebug. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
REPO="hawkff/NekoBoxForAndroid"
PR=14
echo "=== PR info ==="
gh pr view "$PR" --repo "$REPO" --json title,body,files,baseRefName,headRefName
echo ""
echo "=== PR diff ==="
gh pr diff "$PR" --repo "$REPO"Length of output: 5458
Review: Go toolchain bump to 1.26.4Scope verification ✅Exactly 5 files changed, all as declared:
No Language floor unchanged ✅
CI reproducibility ✅All 8 Toolchain sync ✅
No findingsThe PR is surgical and minimal. Everything checks out against the stated scope. [approve] |
1 participant
Summary
Upgrades the Go toolchain across the whole project to the current stable 1.26.4
(from 1.24.9).
libcore/go.modtoolchaingo1.24.9go1.26.4setup-go(all 8 entries: ci/build/preview/release × libcore+mieru jobs)1.24.91.26.4The
go.modlanguage floor (go 1.24.7) is intentionally left unchanged — it states theminimum language version;
toolchain go1.26.4controls the actual compiler.Verification (AWS Linux builder, Go 1.26.4)
starifly/sing-box+libneko+ gomobile + all pinneddeps compile cleanly under Go 1.26.4;
libcore.aarproduced../gradlew app:assembleOssDebug— BUILD SUCCESSFUL (4 ABI APKs).Notes
source or dependency changes were required.
build on 1.26.4.
Scope
libcore/go.mod(toolchain line) + 4 workflow files. No source, no dependency, nosing-box/libneko pin changes.