Skip to content

test: pin updated amneziawg-go core#34

Merged
hawkff merged 1 commit into
mainfrom
test/update-amneziawg-go-upstream
Jun 19, 2026
Merged

test: pin updated amneziawg-go core#34
hawkff merged 1 commit into
mainfrom
test/update-amneziawg-go-upstream

Conversation

@hawkff

@hawkff hawkff commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • pin libcore native source fetch to hawkff/sing-box commit from PR chore: update amneziawg-go to v0.2.19 sing-box#5
  • align libcore with amneziawg-go v0.2.19 for s3/s4 UAPI support
  • keep gvisor.dev/gvisor at the existing June 2025 pseudo-version to avoid a transitive regression

Related

Validation

  • CodeRabbit CLI review: 0 findings
  • cd libcore && go test ./...

Greptile Summary

This PR pins the libcore native source fetch to a new hawkff/sing-box commit and aligns the amneziawg-go dependency to v0.2.19 to gain s3/s4 UAPI support, while explicitly locking gvisor.dev/gvisor to an existing pseudo-version to prevent a transitive regression.

  • get_source_env.sh: COMMIT_SING_BOX is updated to 32aea122… — the downstream fork commit that carries the matching amneziawg-go integration.
  • go.mod: amneziawg-go moves from v1.0.4v0.2.19 (the v0.2.x branch is where active s3/s4 UAPI work lives), golang.org/x/mobile is bumped to a May 2024 pseudo-version, and gvisor.dev/gvisor is explicitly pinned at the June 2025 pseudo-version already present in go.sum.
  • go.sum: New checksums for amneziawg-go v0.2.19 and the updated golang.org/x/mobile are appended; the old v1.0.4 checksums are correctly retained.

Confidence Score: 4/5

Safe to merge assuming hawkff/sing-box#5 is also merged; the dependency changes are intentional and go.sum checksums are consistent.

The amneziawg-go move from v1.0.4 to v0.2.19 is a deliberate semver reversal to pick up features that live on the v0.2.x branch — explained in the PR description, but the kind of version change that is easy to misread in a future go mod tidy or dependency audit. Everything else (commit pin, gvisor explicit lock, mobile bump) is straightforward. No logic changes are made to Go source files.

libcore/go.mod — the amneziawg-go version reversal (v1.0.4 → v0.2.19) is intentional but worth a second look to confirm the v0.2.x branch actually provides the expected UAPI surface.

Important Files Changed

Filename Overview
buildScript/lib/core/get_source_env.sh Bumps COMMIT_SING_BOX to the new hawkff/sing-box commit that carries amneziawg-go v0.2.19 support; COMMIT_LIBNEKO is unchanged.
libcore/go.mod Downgrades amneziawg-go from v1.0.4 to v0.2.19 (intentional per PR — v0.2.x carries s3/s4 UAPI support), bumps golang.org/x/mobile to a May 2024 pseudo-version, and explicitly pins gvisor.dev/gvisor to prevent a transitive regression.
libcore/go.sum Adds checksums for the new amneziawg-go v0.2.19 and golang.org/x/mobile entries; old v1.0.4 hashes are intentionally retained (go.sum is append-only).

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant BS as buildScript/get_source_env.sh
    participant SB as hawkff/sing-box@32aea122
    participant LC as libcore (go.mod)
    participant AWG as amneziawg-go v0.2.19
    participant GV as gvisor.dev/gvisor (pinned)

    BS->>SB: fetch source at COMMIT_SING_BOX
    SB-->>LC: provides sing-box replacement
    LC->>AWG: require v0.2.19 (s3/s4 UAPI support)
    LC->>GV: explicit pin v0.0.0-20250606233247 (prevent transitive regression)
    AWG-->>LC: amneziawg-go indirect dependency resolved
    GV-->>LC: gvisor indirect dependency resolved
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant BS as buildScript/get_source_env.sh
    participant SB as hawkff/sing-box@32aea122
    participant LC as libcore (go.mod)
    participant AWG as amneziawg-go v0.2.19
    participant GV as gvisor.dev/gvisor (pinned)

    BS->>SB: fetch source at COMMIT_SING_BOX
    SB-->>LC: provides sing-box replacement
    LC->>AWG: require v0.2.19 (s3/s4 UAPI support)
    LC->>GV: explicit pin v0.0.0-20250606233247 (prevent transitive regression)
    AWG-->>LC: amneziawg-go indirect dependency resolved
    GV-->>LC: gvisor indirect dependency resolved
Loading

Reviews (1): Last reviewed commit: "test: pin sing-box with updated amneziaw..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hawkff, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 hours, 23 minutes, and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40cd2374-6e72-43cc-9059-4ed90afa8235

📥 Commits

Reviewing files that changed from the base of the PR and between cd76a34 and 21e590e.

⛔ Files ignored due to path filters (1)
  • libcore/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • buildScript/lib/core/get_source_env.sh
  • libcore/go.mod

Comment @coderabbitai help to get the list of available commands and usage tips.

@hawkff hawkff merged commit b4fc248 into main Jun 19, 2026
5 checks passed
@hawkff hawkff deleted the test/update-amneziawg-go-upstream branch June 19, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant