Skip to content

Fix low-contrast selected item in dropdown menus #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hawkff merged 2 commits into from
Jun 20, 2026
Merged

Fix low-contrast selected item in dropdown menus #40

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3c10b
Fix low-contrast selected item in dropdown menus
hawkff Jun 20, 2026
0ddab08
Align dropdown highlight alpha with nav_item_fill (0.16)
hawkff Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/src/main/java/moe/matsuri/nb4a/ui/SimpleMenuPreference.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import android.view.View
import android.view.ViewGroup
import android.widget.ArrayAdapter
import android.widget.Spinner
import androidx.core.graphics.ColorUtils
import androidx.preference.DropDownPreference
import androidx.preference.PreferenceViewHolder
import io.nekohasekai.sagernet.R
Expand Down Expand Up @@ -70,7 +71,14 @@ open class SimpleMenuPreference
var currentPosition = -1

private val radius = 12f * context.resources.displayMetrics.density
private val selectedColor = context.getColorAttr(R.attr.colorMaterial100)

// Highlight the selected item with a translucent primary tint rather than
// an opaque colorMaterial100 fill: the light fill made the (light) item
// text low-contrast on dark themes. ~20% alpha reads on any background
// while keeping the text legible.
private val selectedColor = ColorUtils.setAlphaComponent(
context.getColorAttr(R.attr.colorPrimary), 51
)
Comment thread
greptile-apps[bot] marked this conversation as resolved.

private val topDrawable = GradientDrawable().apply {
setColor(selectedColor)
Expand Down
Loading